Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿš€[PR]: PDF-viewer ๊ตฌํ˜„ #3

Merged
merged 7 commits into from
Dec 29, 2024
Merged

Conversation

Tagite
Copy link
Owner

@Tagite Tagite commented Dec 29, 2024

๐Ÿš€ Pull Request (PR)

โœจ ๋ณ€๊ฒฝ ๋‚ด์šฉ

  • PDF viewer ์ถ”๊ฐ€

๐Ÿ› ๏ธ ๊ตฌํ˜„ ์ƒ์„ธ

  • ๊ตฌํ˜„ํ•œ ๋‚ด์šฉ์˜ ์„ธ๋ถ€ ์‚ฌํ•ญ:
    1. ๋‹จ์ˆœ pdf-viewer์ถ”๊ฐ€
    2. pillow, pymupdf, pyqt5 ์˜์กด์„ฑ ์ถ”๊ฐ€

โœ… ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ฝ”๋“œ๊ฐ€ ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ๋™์ž‘ํ•˜๋Š”์ง€ ํ…Œ์ŠคํŠธ๋ฅผ ์™„๋ฃŒํ–ˆ์Šต๋‹ˆ๋‹ค.
  • Self-review๋ฅผ ์ง„ํ–‰ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ๊ด€๋ จ ๋ฌธ์„œ๋ฅผ ์—…๋ฐ์ดํŠธํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ๋ชจ๋“  ๋ฆฌ๋ทฐ ์ฝ”๋ฉ˜ํŠธ๋ฅผ ๋ฐ˜์˜ํ–ˆ์Šต๋‹ˆ๋‹ค. (ํ•ด๋‹น ์‚ฌํ•ญ์ด ์žˆ์„ ๊ฒฝ์šฐ)

๐Ÿงช ํ…Œ์ŠคํŠธ ๊ฒฐ๊ณผ

  • ์–ด๋–ค ํ…Œ์ŠคํŠธ๋ฅผ ์ˆ˜ํ–‰ํ–ˆ๋‚˜์š”? (์„ ํƒ ์‚ฌํ•ญ):
    • ์˜ˆ: ์œ ๋‹› ํ…Œ์ŠคํŠธ, ํ†ตํ•ฉ ํ…Œ์ŠคํŠธ, ์ˆ˜๋™ ํ…Œ์ŠคํŠธ ๋“ฑ
    • ํ…Œ์ŠคํŠธ ๊ฒฐ๊ณผ๋ฅผ ๊ฐ„๋‹จํžˆ ์ ์–ด์ฃผ์„ธ์š”.

๐Ÿ“ท ์Šคํฌ๋ฆฐ์ƒท (์„ ํƒ ์‚ฌํ•ญ)

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-12-29 20 03 14

๐Ÿ”— ๊ด€๋ จ ์ด์Šˆ (์„ ํƒ ์‚ฌํ•ญ)

๐Ÿ“š ์ถ”๊ฐ€ ์ •๋ณด (์„ ํƒ ์‚ฌํ•ญ)

  • ๋ณ€๊ฒฝ ๋‚ด์šฉ๊ณผ ๊ด€๋ จ๋œ ์ถ”๊ฐ€์ ์ธ ์„ค๋ช…์ด ์žˆ๋‹ค๋ฉด ์ž‘์„ฑํ•ด์ฃผ์„ธ์š”.

์ด์Šˆ ํ…œํ”Œ๋ฆฟ ๊ธฐ๋ณธ ์ œ๋ชฉ ์ถ”๊ฐ€
ruff์™€ pyright๋ฅผ ์ด์šฉํ•œ ๋ฆฐํŒ…, ํฌ๋งคํŒ…, ํƒ€์ž… ์ฒดํฌ๋ฅผ ์ถ”๊ฐ€. pytest๋ฅผ ์ถ”๊ฐ€ ํ•˜์˜€์Šต๋‹ˆ๋‹ค.
๋”๋ฏธ์šฉ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ๋ฅผ ์ถ”๊ฐ€ ํ–ˆ์Šต๋‹ˆ๋‹ค
pdf-viewer๊ธฐ๋Šฅ์„ ์ž„์‹œ๋กœ ์ถ”๊ฐ€. ์ถ”ํ›„ ๋ฆฌํŒฉํ† ๋ง ์˜ˆ์ •

ref: #2
์ด์Šˆ ํ…œํ”Œ๋ฆฟ๋ช…์— ์˜คํƒ€๊ฐ€ ์žˆ์–ด ์ˆ˜์ •
template์˜ ๊ฒฝ๋กœ๋ฅผ ์ˆ˜์ • ํ—€์Šต๋‹ˆ๋‹ค
@Tagite Tagite added the enhancement New feature or request label Dec 29, 2024
@Tagite Tagite self-assigned this Dec 29, 2024
@Tagite Tagite linked an issue Dec 29, 2024 that may be closed by this pull request
@Tagite Tagite merged commit 3b40963 into dev Dec 29, 2024
4 of 5 checks passed
@Tagite Tagite deleted the feature/pdf-viewer branch December 29, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

โœจ[Feat] PDF-viewer ๊ตฌํ˜„
1 participant