Skip to content

Conversation

VasigaranAndAngel
Copy link
Collaborator

Summary

  • Minor type fixes
  • Stop preview with setting media player's source to an empty QUrl.
  • Removed placeholder.mp4

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@CyanVoxel
Copy link
Member

Did you test deleting video files that the media player is currently playing? That's what the placeholder.mp4 was there for before

@VasigaranAndAngel
Copy link
Collaborator Author

Did you test deleting video files that the media player is currently playing? That's what the placeholder.mp4 was there for before

yes i did test. and according to doc setting an empty QUrl as source will release the loaded file.

@CyanVoxel CyanVoxel added Type: Refactor Code that needs to be restructured or cleaned up Status: Review Needed A review of this is needed labels Apr 2, 2025
@CyanVoxel CyanVoxel moved this to 🏓 Ready for Review in TagStudio Development Apr 2, 2025
@CyanVoxel CyanVoxel removed the Status: Review Needed A review of this is needed label May 4, 2025
@CyanVoxel CyanVoxel moved this from 🏓 Ready for Review to 🍃 Pending Merge in TagStudio Development May 4, 2025
@CyanVoxel CyanVoxel added this to the Alpha v9.5.3 milestone May 4, 2025
Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on getting this merged!
I've tested this across macOS, Windows, SSDs, and HDDs and it seems like changes to the media player and its interactions with resource locking are safe. The rest of the type hint fixes are appreciated as well!

@CyanVoxel CyanVoxel changed the base branch from main to Alpha-v9.5.3 May 4, 2025 22:12
@CyanVoxel CyanVoxel merged commit efb0620 into TagStudioDev:Alpha-v9.5.3 May 4, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from 🍃 Pending Merge to ✅ Done in TagStudio Development May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Refactor Code that needs to be restructured or cleaned up

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants