Skip to content

Conversation

CyanVoxel
Copy link
Member

@CyanVoxel CyanVoxel commented Aug 5, 2025

Summary

This PR replaces the placeholder angle bracket symbols ("<", ">") on the navigation icons with proper icons (via boxicons).

The icons respond to the light and dark theme settings, however I'm not sure what the best way would be to have them respond to a disabled QPushButton state or background window dimming, the later of which happens to text in windows on at least macOS for me and leaves the icons popping a bit much. Both of which seem like larger systemic problems that need to be solved with working with Qt, and likely outside the scope of this PR.

Query History Navigation:
image

Pagination Navigation:
image

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@CyanVoxel CyanVoxel added this to the Alpha v9.5.3 milestone Aug 5, 2025
@CyanVoxel CyanVoxel added Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience Priority: Low Doesn't require immediate attention Status: Review Needed A review of this is needed labels Aug 5, 2025
@CyanVoxel CyanVoxel moved this to 🏓 Ready for Review in TagStudio Development Aug 5, 2025
Copy link
Collaborator

@Computerdores Computerdores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't run out of the box because of #1017 but the PR itself looks good

@Computerdores Computerdores moved this from 🏓 Ready for Review to 🍃 Pending Merge in TagStudio Development Aug 5, 2025
@CyanVoxel CyanVoxel removed the Status: Review Needed A review of this is needed label Aug 5, 2025
@CyanVoxel CyanVoxel merged commit 4d4a487 into main Aug 5, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from 🍃 Pending Merge to ✅ Done in TagStudio Development Aug 5, 2025
@CyanVoxel CyanVoxel deleted the nav-arrows branch August 5, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Low Doesn't require immediate attention Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants