Skip to content

fix(ui): fix audio waveform generation on numpy 2.3 #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025
Merged

fix(ui): fix audio waveform generation on numpy 2.3 #1013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/tagstudio/qt/widgets/thumb_renderer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,20 +525,20 @@ def _audio_waveform_thumb(
samples_per_bar: int = 3
size_scaled: int = size * base_scale
allow_small_min: bool = False
im: Image.Image = None
im: Image.Image | None = None

try:
bar_count: int = min(math.floor((size // pixel_ratio) / 5), 64)
audio: AudioSegment = AudioSegment.from_file(filepath, ext[1:])
data = np.fromstring(audio._data, np.int16) # type: ignore
audio = AudioSegment.from_file(filepath, ext[1:])
data = np.frombuffer(buffer=audio._data, dtype=np.int16)
data_indices = np.linspace(1, len(data), num=bar_count * samples_per_bar)
bar_margin: float = ((size_scaled / (bar_count * 3)) * base_scale) / 2
line_width: float = ((size_scaled - bar_margin) / (bar_count * 3)) * base_scale
bar_height: float = (size_scaled) - (size_scaled // bar_margin)

count: int = 0
maximum_item: int = 0
max_array: list = []
max_array: list[int] = []
highest_line: int = 0

for i in range(-1, len(data_indices)):
Expand All @@ -547,7 +547,7 @@ def _audio_waveform_thumb(
count = count + 1
with catch_warnings(record=True):
if abs(d) > maximum_item:
maximum_item = abs(d)
maximum_item = int(abs(d))
else:
max_array.append(maximum_item)

Expand Down