Skip to content

chore(relations): derive scaling_factors length from gating selectors#439

Open
radik878 wants to merge 2 commits into
TaceoLabs:mainfrom
radik878:fix/relation-scaling-factor-lengths
Open

chore(relations): derive scaling_factors length from gating selectors#439
radik878 wants to merge 2 commits into
TaceoLabs:mainfrom
radik878:fix/relation-scaling-factor-lengths

Conversation

@radik878
Copy link
Copy Markdown
Contributor

@radik878 radik878 commented Sep 4, 2025

  • DeltaRangeConstraintRelation: use q_delta_range().len() instead of q_elliptic().len().
  • EccOpQueueRelation: use lagrange_ecc_op().len() instead of q_elliptic().len().

These changes remove copy-paste mistakes and ensure scaling vectors match the actual gating selector of each relation. While prior code worked due to .cycle().take(...), it was semantically incorrect and risky for future maintenance or refactors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant