This repository was archived by the owner on May 4, 2021. It is now read-only.
[BUGFIX] Properly detect "many" relation#4
Open
fsuter wants to merge 3 commits intoTYPO3-extensions:masterfrom
fsuter:master
Open
[BUGFIX] Properly detect "many" relation#4fsuter wants to merge 3 commits intoTYPO3-extensions:masterfrom fsuter:master
fsuter wants to merge 3 commits intoTYPO3-extensions:masterfrom
fsuter:master
Conversation
added 3 commits
February 25, 2014 13:58
Method \TYPO3\CMS\Vidi\Tca\ColumnService::hasRelationMany() relies on "maxitems" or "foreign_table_field" properties to decide whether a field has a "many" relation or not. This is not sufficient. A one-to-many relation may use a MM table if it needs to be bidirectional. In such a case "maxitems" will be 1, but the relation still needs to be detected as a "many" relation.
Conflicts: Classes/Tca/ColumnService.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Method \TYPO3\CMS\Vidi\Tca\ColumnService::hasRelationMany() relies
on "maxitems" or "foreign_table_field" properties to decide
whether a field has a "many" relation or not. This is not
sufficient. A one-to-many relation may use a MM table if it needs
to be bidirectional. In such a case "maxitems" will be 1, but
the relation still needs to be detected as a "many" relation.
Additionally two typos are fixed.