[BUGFIX] Find correct site for mountpoints #4384
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkd-kaehm
force-pushed
the
mountpoint-site
branch
from
d3263fd to
3ea7935
Compare
|
your solution will works only for sites which are on first level in page tree, this is a reason why i suggested to use MP param which already exist there |
dkd-kaehm
force-pushed
the
mountpoint-site
branch
from
3ea7935 to
a1ca8b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
Find correct root page and Site for mountpages.
Before that fix, only the current page id is used to find the correct site. For mountpoints across page trees, this always results in the original site and the page was indexed twice for the original site but not for the correct page tree.
How to test
You need to have multiple page trees. Create a mountpoint of a page inside another page tree and run indexer.
Fixes: #4364