Skip to content

[BUGFIX] Handle deleted workspace records #3427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jschlier wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[BUGFIX] Handle deleted workspace records #3427

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b608af
[BUGFIX] Handle deleted workspace records
jschlier Dec 20, 2022
b7435cb
Merge branch 'TYPO3-Solr:main' into master
jschlier Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Classes/Util.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public static function isDraftRecord(string $table, int $uid): bool
$isWorkspaceRecord = false;

if ((ExtensionManagementUtility::isLoaded('workspaces')) && (BackendUtility::isTableWorkspaceEnabled($table))) {
$record = BackendUtility::getRecord($table, $uid, 'pid, t3ver_state');
$record = BackendUtility::getRecord($table, $uid, 'pid, t3ver_state', '', false);

if ($record['pid'] == '-1' || $record['t3ver_state'] > 0) {
Copy link
Contributor

@froemken froemken Feb 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Officially getRecord() can return either array or null. This patch works, but I would prefer to check for array first, before accessing the array keys.

$isWorkspaceRecord = true;
Expand Down