[FEATURE] RFC: Enable dataProcessing on Results #2763
Conversation
dkd-kaehm
left a comment
dkd-kaehm
left a comment
There was a problem hiding this comment.
Could you please explain some exact use case for this stuff?
|
|
||
| public function __construct() | ||
| { | ||
| $this->contentDataProcessor = GeneralUtility::makeInstance(ContentDataProcessor::class); |
There was a problem hiding this comment.
Please use Injector style, to be able to mock this stuff in tests.
| 'arguments' => $arguments | ||
| ]; | ||
|
|
||
| $values = $this->emitActionSignal(__CLASS__, __FUNCTION__, [$values]); |
There was a problem hiding this comment.
Is this signal unusable for the things you want?
If there is not all what you want, pack this in array.
Would propose to extend all the signals and pack the stuff in the docs and examples.
There was a problem hiding this comment.
Main difference is that Data Processing is configured via typoscript, allowing to plug different configs in places.
Instead of Signals which are global.
There was a problem hiding this comment.
No, i mean that we could plug this stuff via this signal[s], via something like "Facade/Gateway" or some other design pattern.
There was a problem hiding this comment.
The ContentDataProcessor only needs the ContentObjectRenderer which we can get pretty much anywhere injection works. And the configuration from Typoscript of course.
So yeah we could plug it via the signals.
There was a problem hiding this comment.
FYI: signal/slot is deprecated
https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/Hooks/EventDispatcher/Index.html#eventdispatcher
cirk2
force-pushed
the
feature/DataProcessing
branch
from
c443899 to
88bf0d5
Compare
dkd-kaehm
force-pushed
the
release-11.5.x
branch
from
2bfc641 to
b3a9fef
Compare
dkd-kaehm
force-pushed
the
release-11.5.x
branch
from
b0a618c to
ec66f49
Compare
dkd-kaehm
force-pushed
the
release-11.5.x
branch
2 times, most recently
from
caabbba to
e4519e9
Compare
2 participants
What this pr does
Typo3 7.4 Introduced Data Processing for the
FLUIDTEMPLATEcObject. I have found it to be quite useful but it is not globally available in extensions.This PR Enables the feature on the Results Action and should be easy to be expanded to the other actions in the
SearchController.Location of the
dataProcessingblock in the setup is just my first idea, and retrieval of the value probably should be packed into a getter.How to test
Configuration/TypoScript/Examples/DataProcessing/setup.txthas an example for TypoScript setup. A DataProcessor has to be Provided for testing, either one of the ones Supplied by Typo3 or a custom one.