In MenuProcessor allow to specify data fields to include as… … list field1,field2,... #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… list field1,field2,...
twoldanski
requested changes
Feb 12, 2025
Collaborator
There was a problem hiding this comment.
Hi, thanks for contribution!
This feature is duplicating a bit existing feature, but nevertheless we can add this new option to simplify some of the cases of passing new fields).
I added some comments.
PS. if you can please squash commits, so we can have one commit to merge.
| ) { | ||
| // Items to keep | ||
| $removeAll = !isset($processorConfiguration['appendData']) || $processorConfiguration['appendData'] == 0; | ||
| $keepItems = $removeAll ? [] : array_flip(array_map('trim', explode(',', $processorConfiguration['appendData']))); |
Collaborator
There was a problem hiding this comment.
I think we should add new option like keep(Items|fields) or passFields to keep clear what is happening also do not change behavior of flag appendData to keep BC, also you can use GeneralUtility:trimExplode
Collaborator
|
@oliverkroener are you willing to push those changes from review? |
Without a frontendApiProxy in the site config, URLs to local files contain two slashes like www.mysite.org//fileadmin/my-image.jpg
…s#800) This patch prepares backend for nuxt-typo3 implementation.
…-Headless#802) - By default generate language attributes for html tag based on current language page, so nuxt does not have to do it manually - support custom attributes like `config.htmlTag.attributes.class = no-js` with option to override default attributes - Add support for setting body tag attributes via `page.bodyTagAdd` Typoscript directive, so frontend app can automatically apply it via nuxt feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi T3H,
I wanted to include other data in the JSON menu response.
However, appendData only allows 0/1
Often I want to include only certain fields, so I changed the code:
.appendData = field1, field2 ...
This would only include the mentioned fields, not all of them and reduce the size of the payload.
I hope you could agree with my approach (docs will follow later)?
Thanks,
Oliver