-
Notifications
You must be signed in to change notification settings - Fork 0
Feature parallelization #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 23 commits
34f41a8
78c870f
2a69e4d
055dc23
547667b
4493140
9d3259e
a4f2288
8f62e75
8f8f1c3
c2370d2
9e3d099
534ebc0
8ab4514
82606ed
f5ea6b2
abefa7b
541542f
cd8bb35
e198540
5e3344d
6db73d6
12f017a
4b6a272
8b80837
cf31f1e
8803b48
a3e5e20
2bcc602
c0254d0
eb17614
f239072
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,4 +14,6 @@ out | |
| vafator/tests/resources/results | ||
| .cache | ||
| .jupyter | ||
| .local | ||
| .local | ||
| run.sh | ||
| VAFator.egg-info/* | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,11 @@ | ||
| pandas~=1.3.3 | ||
| pysam~=0.19.1 | ||
| cyvcf2~=0.30.14 | ||
| logzero~=1.7.0 | ||
| pybedtools~=0.9.0 | ||
| numpy>=1.20,<2.0 | ||
| scipy>=1.0.0,<2.0.0 | ||
| pandas>=3.0.1,<4 | ||
| # pysam pinned: above 0.21.0 base qualities show up wrong in the presence of soft clipping/insertions/overlapping read pairs or a combination of these factors | ||
| pysam==0.21.0 | ||
| cyvcf2>=0.32.1,<0.33 | ||
| logzero>=1.7.0,<2 | ||
| pybedtools>=0.12.0,<0.13 | ||
| numpy>=2.4.3,<3 | ||
| scipy>=1.17.1,<2 | ||
| setuptools | ||
| pytest | ||
| pytest-cov | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,63 @@ | ||
| [metadata] | ||
| description-file = README.md | ||
| name = VAFator | ||
| version = 3.1.0 | ||
| description = Annotate variants in a VCF file with technical annotations from one or more BAMs | ||
| description-file = README.md | ||
| long_description = file: README.md | ||
| long_description_content_type = text/markdown | ||
| license = MIT | ||
| url = https://github.com/TRON-Bioinformatics/vafator | ||
| author = Pablo Riesgo Ferreiro, Jonas Ibn-Salem, Luis Kress, Özlem Muslu | ||
| classifiers = | ||
| Development Status :: 4 - Beta | ||
| Intended Audience :: Healthcare Industry | ||
| Intended Audience :: Science/Research | ||
| Topic :: Scientific/Engineering :: Bio-Informatics | ||
| Programming Language :: Python :: 3.11 | ||
| Programming Language :: Python :: 3.12 | ||
| Programming Language :: Python :: 3.13 | ||
| Programming Language :: Python :: 3 :: Only | ||
| License :: OSI Approved :: MIT License | ||
| Operating System :: Unix | ||
| author_email = priesgoferreiro@gmail.com | ||
|
|
||
| [options.entry_points] | ||
| console_scripts = | ||
| vafator=vafator.command_line:annotator | ||
| multiallelics-filter=vafator.command_line:multiallelics_filter | ||
| vafator2decifer=vafator.command_line:vafator2decifer | ||
| hatchet2bed=vafator.command_line:hatchet2bed | ||
|
|
||
| [options] | ||
| packages = find: | ||
| include_package_data = True | ||
| zip_safe = False | ||
|
|
||
| python_requires = >=3.11, <3.12 | ||
|
|
||
| install_requires = | ||
| pandas>=3.0.1,<4 | ||
| pysam==0.21.0 # above this version base qualities show up wrong in the presence of soft clipping/insertions/both (latest release 0.23.3) | ||
| cyvcf2>=0.32.1,<0.33 | ||
| logzero>=1.7.0,<2 | ||
| pybedtools>=0.12.0,<0.13 | ||
| numpy>=2.4.3,<3 | ||
| scipy>=1.17.1,<2 | ||
| setuptools | ||
|
|
||
| [options.packages.find] | ||
| exclude = | ||
| tests | ||
| tests.* | ||
| legacy | ||
| legacy.* | ||
|
|
||
| [options.extras_require] | ||
| dev = | ||
| pytest | ||
| ruff | ||
| mypy | ||
| test = | ||
| pytest | ||
| pytest-cov | ||
| setuptools |
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice, thanks for cleaning this up! |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,2 @@ | ||
| VERSION='2.2.2' | ||
|
|
||
|
|
||
| AMBIGUOUS_BASES = ['N', 'M', 'R', 'W', 'S', 'Y', 'K', 'V', 'H', 'D', 'B'] | ||
| VERSION = '3.1.0' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why does this generate v3.1.0? I see that these are breaking changes but wouldn't v3.0.0 be more appropriate?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I bumped the version to 3.0.0 before I made many of the changes, so I thought bumping again would be more appropriate
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If there was no release with v3.0.0 it would be best practice to use v3.0.0 here |
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is pandas used at all? Pandas v3 introduced some major changes that break backward compatibility. If pandas is used, we should check that is works as intended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pandas is used in hachet2bed, ploidies, and vafator2decifer.
My test runs would not include these, I'm not sure how well they are covered in the unit/integration tests either