Skip to content

Commit

Permalink
Merge pull request #3 from DevFactory/release/member-variable-visibil…
Browse files Browse the repository at this point in the history
…ity-should-be-specified-fix-1

squid:S2039 - Member variable visibility should be specified
  • Loading branch information
Lauszus committed May 26, 2016
2 parents ead00a2 + a36900f commit 7657ec9
Show file tree
Hide file tree
Showing 10 changed files with 23 additions and 23 deletions.
4 changes: 2 additions & 2 deletions src/com/tkjelectronics/balanduino/BalanduinoActivity.java
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ public class BalanduinoActivity extends SherlockFragmentActivity implements Acti
public static BluetoothChatService mChatService = null;
public static SensorFusion mSensorFusion = null;

BluetoothDevice btDevice; // The BluetoothDevice object
boolean btSecure; // If it's a new device we will pair with the device
private BluetoothDevice btDevice; // The BluetoothDevice object
private boolean btSecure; // If it's a new device we will pair with the device
public static boolean stopRetrying;

private UnderlinePageIndicator mUnderlinePageIndicator;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public class BluetoothChatService {
public static final int STATE_CONNECTING = 1; // now initiating an outgoing connection
public static final int STATE_CONNECTED = 2; // now connected to a remote device

boolean stopReading; // This is used to stop it from reading on the inputStream
private boolean stopReading; // This is used to stop it from reading on the inputStream
public boolean newConnection; // Prevent it from calling connectionFailed() if it trying to start a new connection

private static final int MAX_RETRIES = 100; // I know this might seem way too high! But it seems to work pretty well
Expand Down
2 changes: 1 addition & 1 deletion src/com/tkjelectronics/balanduino/DeviceListActivity.java
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public void onClick(View v) {
}

private class CustomArrayAdapter extends ArrayAdapter<String> {
boolean selectable;
private boolean selectable;

public CustomArrayAdapter(Context context, int resource) {
super(context, resource);
Expand Down
2 changes: 1 addition & 1 deletion src/com/tkjelectronics/balanduino/ImuFragment.java
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public class ImuFragment extends SherlockFragment {
private Handler mHandler = new Handler();
private Runnable mRunnable;
private int counter = 0;
boolean buttonState;
private boolean buttonState;

@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
Expand Down
4 changes: 2 additions & 2 deletions src/com/tkjelectronics/balanduino/InfoFragment.java
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
import com.actionbarsherlock.app.SherlockFragment;

public class InfoFragment extends SherlockFragment {
static TextView mAppVersion, mFirmwareVersion, mEEPROMVersion, mMcu, mBatteryLevel, mRuntime;
static ToggleButton mToggleButton;
private static TextView mAppVersion, mFirmwareVersion, mEEPROMVersion, mMcu, mBatteryLevel, mRuntime;
protected static ToggleButton mToggleButton;

@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
Expand Down
6 changes: 3 additions & 3 deletions src/com/tkjelectronics/balanduino/JoystickFragment.java
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@
import java.util.Locale;

public class JoystickFragment extends SherlockFragment implements JoystickView.OnJoystickChangeListener {
DecimalFormat d = (DecimalFormat) NumberFormat.getNumberInstance(Locale.ENGLISH);
JoystickView mJoystick;
TextView mText1;
private DecimalFormat d = (DecimalFormat) NumberFormat.getNumberInstance(Locale.ENGLISH);
private JoystickView mJoystick;
private TextView mText1;
private Handler mHandler = new Handler();
private Runnable mRunnable;

Expand Down
6 changes: 3 additions & 3 deletions src/com/tkjelectronics/balanduino/JoystickView.java
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
public class JoystickView extends View {
private OnJoystickChangeListener listener;

final int holo_blue_dark = 0xff0099cc;
final int buttonGray = 0xFF5C5C5C;
private final int holo_blue_dark = 0xff0099cc;
private final int buttonGray = 0xFF5C5C5C;

private int buttonColor = buttonGray;

Expand All @@ -37,7 +37,7 @@ public class JoystickView extends View {
private float centerX;
private float centerY;

Paint p = new Paint();
private Paint p = new Paint();

public JoystickView(Context context) {
super(context);
Expand Down
16 changes: 8 additions & 8 deletions src/com/tkjelectronics/balanduino/PIDFragment.java
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,16 @@ public class PIDFragment extends SherlockFragment {
private static final String TAG = "PIDFragment";
private static final boolean D = BalanduinoActivity.D;

static Button mButton;
static TextView mKpView, mKiView, mKdView, mTargetAngleView;
static SeekBar mKpSeekBar, mKiSeekBar, mKdSeekBar, mTargetAngleSeekBar;
static TextView mKpSeekBarValue, mKiSeekBarValue, mKdSeekBarValue, mTargetAngleSeekBarValue;
private static Button mButton;
private static TextView mKpView, mKiView, mKdView, mTargetAngleView;
private static SeekBar mKpSeekBar, mKiSeekBar, mKdSeekBar, mTargetAngleSeekBar;
private static TextView mKpSeekBarValue, mKiSeekBarValue, mKdSeekBarValue, mTargetAngleSeekBarValue;

float newKpValue, newKiValue, newKdValue, newTargetAngleValue;
float oldKpValue, oldKiValue, oldKdValue, oldTargetAngleValue;
private float newKpValue, newKiValue, newKdValue, newTargetAngleValue;
private float oldKpValue, oldKiValue, oldKdValue, oldTargetAngleValue;

Handler mHandler = new Handler();
int counter = 0;
private Handler mHandler = new Handler();
private int counter = 0;

@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
Expand Down
2 changes: 1 addition & 1 deletion src/com/tkjelectronics/balanduino/SensorFusion.java
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public class SensorFusion implements SensorEventListener {
public Handler mHandler = new Handler();

public static int IMUOutputSelection = -1;
DecimalFormat d = (DecimalFormat) NumberFormat.getNumberInstance(Locale.ENGLISH);
protected DecimalFormat d = (DecimalFormat) NumberFormat.getNumberInstance(Locale.ENGLISH);

public SensorFusion(Context context, SensorManager manager) {
this.context = context;
Expand Down
2 changes: 1 addition & 1 deletion src/com/tkjelectronics/balanduino/ViewPagerAdapter.java
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public class ViewPagerAdapter extends FragmentPagerAdapter {
public static final int PID_FRAGMENT = 3;
public static final int INFO_FRAGMENT = 4;

Context context;
private Context context;

public ViewPagerAdapter(Context context, FragmentManager fm) {
super(fm);
Expand Down

0 comments on commit 7657ec9

Please sign in to comment.