Skip to content

Wolfrednicolas/feature/fix issues in nova resource#9

Merged
joshtorres merged 5 commits into
devfrom
wolfrednicolas/feature/fix-issues-in-nova-resource
May 4, 2021
Merged

Wolfrednicolas/feature/fix issues in nova resource#9
joshtorres merged 5 commits into
devfrom
wolfrednicolas/feature/fix-issues-in-nova-resource

Conversation

@wolfrednicolas
Copy link
Copy Markdown
Contributor

@drewroberts Before merging.

1 - add in the .ENV file the

CLOUDINARY_API_KEY=
CLOUDINARY_API_SECRET=
CLOUDINARY_CLOUD_NAME=

2 - the Scheduler package was fixed and tested here TIPOFF/scheduler#69; however, after some changes, the branch was merged with main branch adding a new implementation => $request->user()->hasPermissionTo('all locations') ... take this a consideration if appear any kind of issue

Copy link
Copy Markdown
Member

@joshtorres joshtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank you!

@joshtorres joshtorres merged commit a28b730 into dev May 4, 2021
@wolfrednicolas wolfrednicolas deleted the wolfrednicolas/feature/fix-issues-in-nova-resource branch May 4, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants