Acute illness usage stats #795
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AronNovak
reviewed
Jul 26, 2023
AronNovak
reviewed
Jul 26, 2023
server/hedley/modules/custom/hedley_admin/scripts/generate-acute-illness-completion-report.php
Outdated
Show resolved
Hide resolved
AronNovak
reviewed
Jul 26, 2023
server/hedley/modules/custom/hedley_admin/scripts/generate-acute-illness-completion-report.php
Outdated
Show resolved
Hide resolved
AronNovak
reviewed
Jul 26, 2023
server/hedley/modules/custom/hedley_admin/scripts/generate-acute-illness-completion-report.php
Outdated
Show resolved
Hide resolved
AronNovak
reviewed
Jul 26, 2023
server/hedley/modules/custom/hedley_admin/scripts/generate-acute-illness-completion-report.php
Outdated
Show resolved
Hide resolved
AronNovak
reviewed
Jul 26, 2023
server/hedley/modules/custom/hedley_admin/scripts/generate-acute-illness-completion-report.php
Outdated
Show resolved
Hide resolved
AronNovak
reviewed
Jul 26, 2023
server/hedley/modules/custom/hedley_admin/scripts/generate-acute-illness-completion-report.php
Outdated
Show resolved
Hide resolved
AronNovak
reviewed
Jul 26, 2023
server/hedley/modules/custom/hedley_admin/scripts/generate-acute-illness-completion-report.php
Show resolved
Hide resolved
AronNovak
reviewed
Jul 26, 2023
| } | ||
| $count = 0; | ||
| foreach ($ids as $id) { | ||
| if ($id == count($constraints)) { |
There was a problem hiding this comment.
This is not easily understandable what do we do here. Can we explain it in a comment? Thanks!
AronNovak
reviewed
Jul 26, 2023
|
|
||
| $count = 0; | ||
| foreach ($ids as $id) { | ||
| if ($id == count($constraints) - $modifier) { |
There was a problem hiding this comment.
same as above, worth a comment, not trivial to follow the intention
There was a problem hiding this comment.
Hey Aron - I added some explanatory comments to this section and the one mentioned above. Please let me know if you feel it could still benefit from a more detailed explanation or if it's good where it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.