RM- Debugging Missing CSS #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvmn
requested changes
Feb 11, 2025
| @@ -431,143 +431,86 @@ function hedley_admin_administrators_access() { | |||
| * This function generates a table displaying the resilience survey results. | |||
| */ | |||
| function hedley_admin_resilience_survey_results_table(array $form, array &$form_state) { | |||
| $header = array( | |||
| drupal_add_css('.align-center { text-align: center; }', ['type' => 'inline']); | |||
|
|
||
| $survey_answers = explode('|', $survey_answers_raw); | ||
| $answers_processed = []; | ||
| if (empty($result['node'])) return []; |
| if (count($parts) === 2) { | ||
| list($question, $answer) = $parts; | ||
| $question_number = str_replace('q', '', $question); | ||
| foreach (node_load_multiple(array_keys($result['node'])) as $node) { |
There was a problem hiding this comment.
Not best styling. Hard to read. First load nodes, then run loop.
| $question_number = str_replace('q', '', $question); | ||
| foreach (node_load_multiple(array_keys($result['node'])) as $node) { | ||
| $nurse_id = field_get_items('node', $node, 'field_nurse')[0]['target_id'] ?? NULL; | ||
| $nurse_name = $nurse_id ? (node_load($nurse_id)->title ?? 'Unknown Nurse') : 'Unknown Nurse'; |
There was a problem hiding this comment.
Again, too much in one row. Separate for better readability.
Also ?? is php 8 operator. We're using php 7. Can't use it.
| $nurse_node = node_load($nurse_id); | ||
| if ($nurse_node) { | ||
| $health_center_id = field_get_items('node', $nurse_node, 'field_health_centers')[0]['target_id'] ?? NULL; | ||
| $health_center_name = $health_center_id ? (node_load($health_center_id)->title ?? 'Unknown Center') : 'Unknown Center'; |
There was a problem hiding this comment.
Again, too much in one row. Separate for better readability.
Also ?? is php 8 operator. We're using php 7. Can't use it.
|
|
||
| if ($question_number >= 1 && $question_number <= 12) { | ||
| $answers_processed["question_$question_number"] = $answer; | ||
| $survey_type = field_get_items('node', $node, 'field_resilience_survey_type')[0]['value'] ?? 'Unknown'; |
| if ($question_number >= 1 && $question_number <= 12) { | ||
| $answers_processed["question_$question_number"] = $answer; | ||
| $survey_type = field_get_items('node', $node, 'field_resilience_survey_type')[0]['value'] ?? 'Unknown'; | ||
| $date_measured = field_get_items('node', $node, 'field_date_measured')[0]['value'] ?? 'Unknown'; |
| } | ||
|
|
||
| $form_state['rows'] = $rows; | ||
| $form['csv_export_button'] = ['#type' => 'submit', '#value' => t('Export to CSV'), '#submit' => ['hedley_admin_resilience_survey_export_csv']]; |
There was a problem hiding this comment.
Can't be single line. Revert.
| } | ||
|
|
||
| $form_state['rows'] = $rows; | ||
| $form['csv_export_button'] = ['#type' => 'submit', '#value' => t('Export to CSV'), '#submit' => ['hedley_admin_resilience_survey_export_csv']]; | ||
| $form['table'] = ['#theme' => 'table', '#header' => $header, '#rows' => $rows, '#empty' => t('No survey results available')]; |
There was a problem hiding this comment.
Can't be single line. Revert.
|
Coder failure:
|
anvmn
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1400