-
Notifications
You must be signed in to change notification settings - Fork 9
Added individual pages for UI styling common questions #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run npm run format
cursor: pointer; | ||
} | ||
.fa-step-forward { | ||
order: -100; /* to the right of the play/pause-button */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: (non-blocking) @jpestugia I'm a little ignorant on the layout of the components here, but what order does the play/pause button have here? It can't be between -101 and -100. Is it just -100 but it comes before the forward button in the HTML?
authors: [jedd.pestugia] | ||
--- | ||
|
||
For a more detailed overview about player customisation, please see the [Player documentation](/theoplayer/getting-started/sdks/web/getting-started/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (non-blocking) @jpestugia Is there any style guide on US vs. UK spellings? I'm thinking about the "s" in "customisation" which is a "z" in en-us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@turbidwater , good question, this is likely more of a marketing question. I will ask and adjust.
|
||
| Web SDK | Android SDK | iOS SDK | tvOS SDK | Android TV SDK | Chromecast SDK | | ||
| :-----: | :---------: | :-----: | :------: | :------------: | :------------: | | ||
| Yes | Yes | Yes | Yes | Yes | Yes | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: @jpestugia I don't know if you'd want to include the Roku SDK here. It does the error handling and events, but it does not have the customizable UI. Clients can turn off the native UI and implement their own, but we don't have a Custom UI equivalent for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this article feels out of place. It's not really about the UI at all, it's just talking about our error events on the Player API... 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MattiasBuelens @turbidwater , agreed that this section (the whole playback/web/uistyling) feels slightly out of place as it's not THEOLive specific, but the idea was to answer a few common customer questions that came up and provide some quick access answers. If better, happy to create a more generic section to point towards the more logical section (anywhere within /theoplayer).
Can you check that all directory names are lowercase and don't contain spaces? I see the file path has |
The code below inserts two buttons in the control bar, lets viewers jump in time when it is clicked, and adds a tooltip to the button. | ||
|
||
```js | ||
// setting up the rewind button by setting up a video-js component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should really use Open Video UI for Web instead. Our video.js UI should be considered legacy.
|
||
| Web SDK | Android SDK | iOS SDK | tvOS SDK | Android TV SDK | Chromecast SDK | | ||
| :-----: | :---------: | :-----: | :------: | :------------: | :------------: | | ||
| Yes | Yes | Yes | Yes | Yes | Yes | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this article feels out of place. It's not really about the UI at all, it's just talking about our error events on the Player API... 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably did not intend to update these submodules as part of this PR? You may want to revert those changes. 🙂
No description provided.