Derek/ticket 379 Add generic file picker control for file inputs#427
Open
derekllanes wants to merge 6 commits into
Open
Derek/ticket 379 Add generic file picker control for file inputs#427derekllanes wants to merge 6 commits into
derekllanes wants to merge 6 commits into
Conversation
…efault for processing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for generic file inputs as GUI controls
The intended behavior is:
gr.File(...)inputs for MIDI files (.mid,.midi) still behave as MIDI tracks.gr.File(...)inputs become a generic file picker control in the GUI.app.py.file_types.In the HARP UI, the new control appears as:
Browse...buttonNo file selectedor the selected file pathWhat Changed
pyharp:
HARP:
TESTING
While testing with the updated "ui_tester" in pyharp is working. Note that extensive testing has not been done.