[#13454] Refactor instructor search page to remove unnecessary API calls - #14409
Open
codigm wants to merge 3 commits into
Open
[#13454] Refactor instructor search page to remove unnecessary API calls#14409codigm wants to merge 3 commits into
codigm wants to merge 3 commits into
Conversation
|
Hi @codigm, all PR guideline checks have passed. Thank you for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13454
Outline of Solution
loadInstructorPrivilegewas being called for each unique student sectioninstead of once per course, causing redundant API calls. Results also weren't
cached across searches.
Changes:
getPrivileges()now fetches once per unique courseId usingforkJoinwitha keyed
Recordinstead of an unkeyed arrayprivilegeCacheMap to avoid re-fetching on subsequent searchescombinePrivileges()uses Map lookup by courseId instead of relying onforkJoinarray ordering viashift()TransformedInstructorSearchResultwrapper interfacesearch()RxJS pipeline