대시보드_최근_목록_클릭_기능_추가 #555
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -704,7 +704,23 @@ public AdminResponse getRecentItemsForAdmin(int limit) { | |
|
|
||
| return AdminResponse.builder() | ||
| .items(adminItemDtoPage) | ||
| .totalCount(adminItemDtoPage.getTotalElements()) | ||
| .build(); | ||
| } | ||
|
|
||
| /** | ||
| * 관리자용 물품 단건 조회 | ||
| */ | ||
| @Transactional(readOnly = true) | ||
| public AdminResponse getItemDetailForAdmin(AdminRequest request) { | ||
| Item item = itemRepository.findByItemIdWithDetails(request.getItemId()) | ||
| .orElseThrow(() -> { | ||
| log.error("관리자 물품 단건 조회 실패 - 존재하지 않는 itemId: {}", request.getItemId()); | ||
| return new CustomException(ErrorCode.ITEM_NOT_FOUND); | ||
| }); | ||
|
|
||
| return AdminResponse.builder() | ||
| .item(item) | ||
| .build(); | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -297,17 +297,34 @@ public AdminResponse getRecentMembersForAdmin(int limit) { | |
| .profileUrl(member.getProfileUrl()) | ||
| .email(member.getEmail()) | ||
| .isActive(!member.getIsDeleted()) | ||
| .accountStatus(member.getAccountStatus()) | ||
| .createdDate(member.getCreatedDate()) | ||
| .lastLoginDate(member.getLastActiveAt()) | ||
| .build() | ||
| ); | ||
|
|
||
| return AdminResponse.builder() | ||
| .members(adminMemberDtoPage) | ||
| .totalCount(adminMemberDtoPage.getTotalElements()) | ||
| .build(); | ||
| } | ||
|
|
||
| /** | ||
| * 관리자용 회원 단건 조회 | ||
| */ | ||
| @Transactional(readOnly = true) | ||
| public AdminResponse getMemberDetailForAdmin(AdminRequest request) { | ||
| Member member = memberRepository.findById(request.getMemberId()) | ||
| .orElseThrow(() -> { | ||
| log.error("관리자 회원 단건 조회 실패 - 존재하지 않는 memberId: {}", request.getMemberId()); | ||
| return new CustomException(ErrorCode.MEMBER_NOT_FOUND); | ||
| }); | ||
|
|
||
| return AdminResponse.builder() | ||
| .member(member) | ||
| .build(); | ||
| } | ||
|
|
||
|
Comment on lines
+312
to
+327
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== 1. AdminRequest 검증 어노테이션 확인 =="
fd -t f 'AdminRequest.java' | head -5 | while read file; do
echo "--- $file ---"
cat -n "$file" || true
done
echo
echo "== 2. AdminApiController에서 getMemberDetail 관련 코드 확인 =="
fd -t f 'AdminApiController.java' | head -1 | while read file; do
echo "--- $file ---"
cat -n "$file" | grep -A 20 -B 5 "getMemberDetail\|@Valid\|@Validated" || true
done
echo
echo "== 3. MemberService에서 findMemberById 메서드 확인 =="
fd -t f 'MemberService.java' | head -1 | while read file; do
echo "--- $file ---"
cat -n "$file" | sed -n '330,345p'
done
echo
echo "== 4. MemberService에서 Admin 관련 메서드 검색 =="
fd -t f 'MemberService.java' | head -1 | while read file; do
echo "--- $file ---"
rg -n 'public.*Admin|getMemberDetail' "$file" || true
doneRepository: TEAM-ROMROM/RomRom-BE Length of output: 5210 관리자 회원 단건 조회:
제안 diff (중복 제거 방향) `@Transactional`(readOnly = true)
public AdminResponse getMemberDetailForAdmin(AdminRequest request) {
- Member member = memberRepository.findById(request.getMemberId())
- .orElseThrow(() -> {
- log.error("관리자 회원 단건 조회 실패 - 존재하지 않는 memberId: {}", request.getMemberId());
- return new CustomException(ErrorCode.MEMBER_NOT_FOUND);
- });
+ // AdminRequest에 `@NotNull` + 컨트롤러에 `@Valid` 추가 필수
+ Member member = findMemberById(request.getMemberId());
return AdminResponse.builder()
.member(member)
.build();
}🤖 Prompt for AI Agents |
||
| /** | ||
| * PK 기반 회원조회 | ||
| */ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,14 +22,15 @@ | |
| @RequiredArgsConstructor | ||
| @RequestMapping("/api/admin") | ||
| @Slf4j | ||
| public class AdminApiController implements AdminApiControllerDocs { | ||
|
|
||
| private final AdminAuthService adminAuthService; | ||
| private final ItemService itemService; | ||
| private final MemberService memberService; | ||
| private final AdminReportService adminReportService; | ||
|
|
||
|
|
||
| @Override | ||
| @PostMapping(value = "/login", consumes = MediaType.MULTIPART_FORM_DATA_VALUE) | ||
| public ResponseEntity<AdminResponse> login(@ModelAttribute AdminRequest request, | ||
| HttpServletResponse response) { | ||
|
|
@@ -71,6 +72,7 @@ public ResponseEntity<AdminResponse> login(@ModelAttribute AdminRequest request, | |
| } | ||
| } | ||
|
|
||
| @Override | ||
| @PostMapping(value = "/logout", consumes = MediaType.MULTIPART_FORM_DATA_VALUE) | ||
| public ResponseEntity<Void> logout(@CookieValue(value = "refreshToken", required = false) String refreshTokenFromCookie, | ||
| HttpServletResponse response) { | ||
|
|
@@ -104,6 +106,7 @@ public ResponseEntity<Void> logout(@CookieValue(value = "refreshToken", required | |
|
|
||
| // ==================== Dashboard ==================== | ||
|
|
||
| @Override | ||
| @GetMapping("/dashboard/stats") | ||
| @LogMonitor | ||
| public ResponseEntity<AdminResponse> getDashboardStats() { | ||
|
|
@@ -115,12 +118,14 @@ public ResponseEntity<AdminResponse> getDashboardStats() { | |
| .build()); | ||
| } | ||
|
|
||
| @Override | ||
| @GetMapping("/dashboard/recent-members") | ||
| @LogMonitor | ||
| public ResponseEntity<AdminResponse> getRecentMembers() { | ||
| return ResponseEntity.ok(memberService.getRecentMembersForAdmin(8)); | ||
| } | ||
|
|
||
| @Override | ||
| @GetMapping("/dashboard/recent-items") | ||
| @LogMonitor | ||
| public ResponseEntity<AdminResponse> getRecentItems() { | ||
|
|
@@ -129,12 +134,21 @@ public ResponseEntity<AdminResponse> getRecentItems() { | |
|
|
||
| // ==================== Items ==================== | ||
|
|
||
| @Override | ||
| @PostMapping(value = "/items/detail", consumes = MediaType.MULTIPART_FORM_DATA_VALUE) | ||
| @LogMonitor | ||
| public ResponseEntity<AdminResponse> getItemDetail(@ModelAttribute AdminRequest request) { | ||
| return ResponseEntity.ok(itemService.getItemDetailForAdmin(request)); | ||
| } | ||
|
|
||
| @Override | ||
| @GetMapping("/items") | ||
| @LogMonitor | ||
| public ResponseEntity<AdminResponse> getItems(@ModelAttribute AdminRequest request) { | ||
| return ResponseEntity.ok(itemService.getItemsForAdmin(request)); | ||
| } | ||
|
|
||
| @Override | ||
| @DeleteMapping("/items/{itemId}") | ||
| @LogMonitor | ||
| public ResponseEntity<Void> deleteItem(@PathVariable UUID itemId) { | ||
|
|
@@ -144,6 +158,14 @@ public ResponseEntity<Void> deleteItem(@PathVariable UUID itemId) { | |
|
|
||
| // ==================== Members ==================== | ||
|
|
||
| @Override | ||
| @PostMapping(value = "/members/detail", consumes = MediaType.MULTIPART_FORM_DATA_VALUE) | ||
| @LogMonitor | ||
| public ResponseEntity<AdminResponse> getMemberDetail(@ModelAttribute AdminRequest request) { | ||
| return ResponseEntity.ok(memberService.getMemberDetailForAdmin(request)); | ||
| } | ||
|
|
||
| @Override | ||
| @GetMapping("/members") | ||
| @LogMonitor | ||
| public ResponseEntity<AdminResponse> getMembers(@ModelAttribute AdminRequest request) { | ||
|
|
@@ -152,6 +174,7 @@ public ResponseEntity<AdminResponse> getMembers(@ModelAttribute AdminRequest req | |
|
|
||
| // ==================== Reports ==================== | ||
|
|
||
| @Override | ||
| @PostMapping("/reports") | ||
| @LogMonitor | ||
| public ResponseEntity<AdminReportResponse> handleReports(@RequestBody AdminReportRequest request) { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
문서 규칙과 실제 구현이 어긋날 수 있어 예외/범위를 명시해두는 게 좋겠습니다.
@ModelAttribute”를 “전체 공통”으로 선언했는데, 이번 PR의AdminApiController만 봐도GET /dashboard/*,GET /items,GET /members,DELETE /items/{itemId}가 존재합니다. “예외 케이스(예: 조회는 GET, 삭제는 DELETE 등)”를 문서에 같이 적어두면 혼선이 줄어들어요.또한 markdownlint 힌트(MD040)처럼 Line 55의 fenced code block에 언어가 빠져 있습니다.
제안 diff (MD040 해결)
Also applies to: 52-66
🤖 Prompt for AI Agents