-
Notifications
You must be signed in to change notification settings - Fork 1
main 최신화 #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[🐛BUG] QA 시리즈
|
Caution Review failedThe pull request is closed. Walkthrough여러 화면에서 할 일 추가 시 Amplitude 이벤트 트래킹을 도입하고(커뮤니티/직무 상세/타인 할 일), 커뮤니티 사이드바 클릭 이동 및 기본 프로필 이미지 처리, 리크루트 카드 클릭 시 모달 상세 보기 추가, 일부 타입 스키마 확장(todoGroupId, url, profileImage nullable), 체크리스트 UI의 AddIcon 요소 제거가 포함됩니다. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User
participant C as UI (Community/JobDetail/Other)
participant A as trackTodoImport
participant M as Add/Delete Mutation
participant T as Toast
U->>C: "추가" 버튼 클릭
alt 아직 추가되지 않음
C->>A: trackTodoImport(title)
A-->>C: (완료)
C->>M: addTodoMutation
M-->>C: 성공
C->>T: "할일이 추가되었습니다." 표시(2s)
else 이미 추가됨
C->>M: deleteTodoMutation
M-->>C: 성공
C->>T: "할일이 취소되었습니다." 표시(2s)
end
sequenceDiagram
autonumber
actor U as User
participant H as HomeRecruit List
participant D as Converter(convertToRecruitItem)
participant MD as Modal(CardDetail)
U->>H: 카드 클릭
H->>D: 데이터 변환(RecruitData → RecruitItem)
D-->>H: RecruitItem
H->>MD: 모달 열기(item=RecruitItem)
U-->>MD: 닫기 클릭
MD-->>H: 모달 닫기
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (12)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 풀 리퀘스트 제안
📋 작업 내용
📸 스크린샷 (선택 사항)
📄 기타
Summary by CodeRabbit
New Features
Style