Conversation
📝 WalkthroughSummary by CodeRabbit릴리스 노트
Walkthrough
Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~30 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/host/src/pages/notice-list/notice-list.tsx`:
- Around line 67-75: The catch block in handleCopyLink swallows errors so users
get no feedback on copy failures; update handleCopyLink to catch the exception
from navigator.clipboard.writeText and call toast.show with an error message
(e.g., '링크 복사에 실패했습니다.') to mirror the success toast, and optionally log the
caught error for debugging (use the existing toast.show and any local logger if
available).
In `@packages/ads-ui/src/components/button/add-to-watch/add-to-watch.tsx`:
- Around line 27-30: The button is always rendering aria-pressed which misuses
ARIA for non-toggle actions; change the AddToWatch component so aria-pressed is
only added when the component is actually a toggle (e.g., when the selected prop
is provided/used or an explicit isToggle prop is true). Update the JSX that
currently sets aria-pressed={selected} (in add-to-watch.tsx / AddToWatch) to
conditionally include the attribute (only when selected !== undefined or
isToggle === true) and leave it out for non-toggle actions like copy-link so
downstream callers can omit selected.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 57819d86-fe86-4f91-969e-5d68c6d8ba5b
⛔ Files ignored due to path filters (1)
packages/ads-ui/src/icons/svgs/icn_copy.svgis excluded by!**/*.svg,!**/*.svgand included bypackages/**/src/**
📒 Files selected for processing (5)
apps/audience/src/pages/notice-list/notice-list.tsxapps/host/src/pages/notice-list/notice-list.tsxpackages/ads-ui/src/components/button/add-to-watch/add-to-watch.css.tspackages/ads-ui/src/components/button/add-to-watch/add-to-watch.tsxpackages/ads-ui/src/icons/index.ts
packages/ads-ui/src/components/button/add-to-watch/add-to-watch.tsx
Outdated
Show resolved
Hide resolved
Sohyunnnn
left a comment
There was a problem hiding this comment.
수고많으셨습니다 👍
코멘트 몇 개 작성했는데 참고 부탁드립니다!!
packages/ads-ui/src/components/button/add-to-watch/add-to-watch.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/ads-ui/src/components/button/add-to-watch/action-button.css.ts`:
- Line 5: Rename the generic style identifier `button` to a more descriptive
`actionButton` in the CSS module (update the exported constant name from
`button` to `actionButton`) and then update the corresponding component
`add-to-watch/action-button.tsx` to import and use the renamed `actionButton`
identifier (ensure any usages, className assignments or destructured imports
referencing `button` are replaced with `actionButton` and the export remains
default/ named consistent with the module).
In `@packages/ads-ui/src/components/index.ts`:
- Line 6: Restore a backward-compatible alias export so consumers can continue
using AddToWatchButton while encouraging migration to ActionButton: in the
components index module (where ActionButton is exported from
'./button/add-to-watch/action-button'), also export AddToWatchButton as a named
export that references the same default component (i.e., export AddToWatchButton
as an alias of ActionButton) and add a short deprecation comment; keep this
alias available for at least one release to allow gradual migration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 4b792dbe-81cf-43f9-928b-47c418917122
📒 Files selected for processing (7)
apps/audience/src/pages/notice-list/notice-list.tsxapps/host/src/pages/notice-list/notice-list.tsxpackages/ads-ui/src/components/button/add-to-watch/action-button.css.tspackages/ads-ui/src/components/button/add-to-watch/action-button.tsxpackages/ads-ui/src/components/button/add-to-watch/add-to-watch.tsxpackages/ads-ui/src/components/index.tspackages/apis/src/constants/env.ts
💤 Files with no reviewable changes (1)
- packages/ads-ui/src/components/button/add-to-watch/add-to-watch.tsx
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
packages/ads-ui/src/components/index.ts (1)
6-6:⚠️ Potential issue | 🟠 MajorMust:
AddToWatchButton공개 export를 최소 한 릴리즈 동안 alias로 유지해 주세요.현재 변경은 디자인 시스템 공개 API에서 기존 이름을 즉시 제거하는 형태라 소비처에 브레이킹 체인지가 됩니다.
ActionButton으로 마이그레이션 유도는 좋지만, deprecated alias를 병행 노출해 점진 전환해 주세요.호환 레이어 제안
export { default as ActionButton } from './button/add-to-watch/action-button'; +// Deprecated: 다음 메이저 릴리즈에서 제거 예정 +export { default as AddToWatchButton } from './button/add-to-watch/action-button';As per coding guidelines
packages/ads-ui/src/**: "디자인 시스템 패키지예요. - props/스타일 변경 시 영향 범위 확인"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/ads-ui/src/components/index.ts` at line 6, Keep a backward-compatible alias export so consumers using AddToWatchButton won’t break: in packages/ads-ui/src/components/index.ts continue exporting the new default as ActionButton (export { default as ActionButton } from './button/add-to-watch/action-button') and add a deprecated alias export for AddToWatchButton that re-exports the same default (i.e., export { default as AddToWatchButton } from './button/add-to-watch/action-button'), include a brief deprecation comment above the alias to indicate it will be removed in a future release so callers can migrate.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/host/src/pages/notice-list/notice-list.tsx`:
- Around line 73-81: handleCopyLink currently concatenates ENV.AUDIENCE_BASE_URL
and eventId without validation, allowing missing/misconfigured base URLs to
produce bad links; update handleCopyLink to validate ENV.AUDIENCE_BASE_URL first
(e.g., attempt to construct a new URL(base, path) using the URL constructor) and
only call navigator.clipboard.writeText when URL construction succeeds,
otherwise show an error toast; reference the handleCopyLink function,
ENV.AUDIENCE_BASE_URL, navigator.clipboard.writeText and toast.show when
implementing this change.
---
Duplicate comments:
In `@packages/ads-ui/src/components/index.ts`:
- Line 6: Keep a backward-compatible alias export so consumers using
AddToWatchButton won’t break: in packages/ads-ui/src/components/index.ts
continue exporting the new default as ActionButton (export { default as
ActionButton } from './button/add-to-watch/action-button') and add a deprecated
alias export for AddToWatchButton that re-exports the same default (i.e., export
{ default as AddToWatchButton } from './button/add-to-watch/action-button'),
include a brief deprecation comment above the alias to indicate it will be
removed in a future release so callers can migrate.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: e2db5f6f-aa48-4370-b941-1b5d3e3241f4
📒 Files selected for processing (3)
apps/audience/src/pages/notice-list/notice-list.tsxapps/host/src/pages/notice-list/notice-list.tsxpackages/ads-ui/src/components/index.ts
📌 Summary
📚 Tasks
🔍 Describe
주최사 링크 추출 버튼 컴포넌트 구현
AddToWatchButton을 재사용하기 위해 아이콘, 텍스트를 변경할 수 있도록 수정했어요.👀 To Reviewer
📸 Screenshot
2026-03-13.5.23.51.mov