Open
Conversation
2 tasks
📝 WalkthroughSummary by CodeRabbit릴리스 노트
WalkthroughAddToWatchButton 컴포넌트를 ActionButton으로 대체하고 스타일링을 재구성합니다. 호스트 페이지에 알림 공유 링크 기능을 추가하며, 환경 변수에 AUDIENCE_BASE_URL을 등록하고 새로운 CopyIcon을 아이콘 라이브러리에 추가합니다. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~30 분 Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/host/src/pages/notice-list/notice-list.tsx`:
- Around line 67-75: The catch block in handleCopyLink swallows errors so users
get no feedback on copy failures; update handleCopyLink to catch the exception
from navigator.clipboard.writeText and call toast.show with an error message
(e.g., '링크 복사에 실패했습니다.') to mirror the success toast, and optionally log the
caught error for debugging (use the existing toast.show and any local logger if
available).
In `@packages/ads-ui/src/components/button/add-to-watch/add-to-watch.tsx`:
- Around line 27-30: The button is always rendering aria-pressed which misuses
ARIA for non-toggle actions; change the AddToWatch component so aria-pressed is
only added when the component is actually a toggle (e.g., when the selected prop
is provided/used or an explicit isToggle prop is true). Update the JSX that
currently sets aria-pressed={selected} (in add-to-watch.tsx / AddToWatch) to
conditionally include the attribute (only when selected !== undefined or
isToggle === true) and leave it out for non-toggle actions like copy-link so
downstream callers can omit selected.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 57819d86-fe86-4f91-969e-5d68c6d8ba5b
⛔ Files ignored due to path filters (1)
packages/ads-ui/src/icons/svgs/icn_copy.svgis excluded by!**/*.svg,!**/*.svgand included bypackages/**/src/**
📒 Files selected for processing (5)
apps/audience/src/pages/notice-list/notice-list.tsxapps/host/src/pages/notice-list/notice-list.tsxpackages/ads-ui/src/components/button/add-to-watch/add-to-watch.css.tspackages/ads-ui/src/components/button/add-to-watch/add-to-watch.tsxpackages/ads-ui/src/icons/index.ts
packages/ads-ui/src/components/button/add-to-watch/add-to-watch.tsx
Outdated
Show resolved
Hide resolved
Sohyunnnn
approved these changes
Mar 13, 2026
Contributor
Sohyunnnn
left a comment
Sohyunnnn
left a comment
There was a problem hiding this comment.
수고많으셨습니다 👍
코멘트 몇 개 작성했는데 참고 부탁드립니다!!
packages/ads-ui/src/components/button/add-to-watch/add-to-watch.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/ads-ui/src/components/button/add-to-watch/action-button.css.ts`:
- Line 5: Rename the generic style identifier `button` to a more descriptive
`actionButton` in the CSS module (update the exported constant name from
`button` to `actionButton`) and then update the corresponding component
`add-to-watch/action-button.tsx` to import and use the renamed `actionButton`
identifier (ensure any usages, className assignments or destructured imports
referencing `button` are replaced with `actionButton` and the export remains
default/ named consistent with the module).
In `@packages/ads-ui/src/components/index.ts`:
- Line 6: Restore a backward-compatible alias export so consumers can continue
using AddToWatchButton while encouraging migration to ActionButton: in the
components index module (where ActionButton is exported from
'./button/add-to-watch/action-button'), also export AddToWatchButton as a named
export that references the same default component (i.e., export AddToWatchButton
as an alias of ActionButton) and add a short deprecation comment; keep this
alias available for at least one release to allow gradual migration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 4b792dbe-81cf-43f9-928b-47c418917122
📒 Files selected for processing (7)
apps/audience/src/pages/notice-list/notice-list.tsxapps/host/src/pages/notice-list/notice-list.tsxpackages/ads-ui/src/components/button/add-to-watch/action-button.css.tspackages/ads-ui/src/components/button/add-to-watch/action-button.tsxpackages/ads-ui/src/components/button/add-to-watch/add-to-watch.tsxpackages/ads-ui/src/components/index.tspackages/apis/src/constants/env.ts
💤 Files with no reviewable changes (1)
- packages/ads-ui/src/components/button/add-to-watch/add-to-watch.tsx
jin-evergreen
approved these changes
Mar 14, 2026
Comment on lines
+65
to
+70
| navigate( | ||
| ROUTE_PATH.NOTICE_DETAILS.replace(':eventId', String(eventId)).replace( | ||
| ':noticeId', | ||
| String(noticeId), | ||
| ), | ||
| ); |
Member
There was a problem hiding this comment.
지금 바로 수정할 수 있는 부분은 아니지만, 아래 PR에서 빌더를 만들어둬서 해당 PR이 머지되면 .replace를 사용하는 것보다 더 간단히 구현할 수 있을 것 같아요!
navigate(ROUTE_PATH.noticeDetails(eventId, noticeId));
이 부분은 추후에 천천히 반영하면 될 것 같습니다~!!😀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
📚 Tasks
🔍 Describe
주최사 링크 추출 버튼 컴포넌트 구현
AddToWatchButton을 재사용하기 위해 아이콘, 텍스트를 변경할 수 있도록 수정했어요.👀 To Reviewer
📸 Screenshot
2026-03-13.5.23.51.mov