-
Notifications
You must be signed in to change notification settings - Fork 2
Feat(audience): 내 관람 공연 카드 클릭 시 공연 상세 페이지로 이동 구현 #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from 5 commits
133fb51
657d482
68d72a4
cb790ef
9f6614c
51789eb
f31e637
b01e1c4
d6acd0f
57f712d
062ee50
26c4e20
d16e8cd
2089485
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,26 +7,22 @@ import type { | |
| WishListResponseData, | ||
| } from '@shared/types/festival'; | ||
| import type { | ||
| AllFestivalsResponse, | ||
| FestivalsResponse, | ||
| NicknameResponse, | ||
| UpcomingFestivalResponse, | ||
| UpcomingFestivalsResponse, | ||
| UpcomingFestivalItem, | ||
| } from '@shared/types/home-response'; | ||
|
Comment on lines
+10
to
12
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion | 🟠 Major Suggest:
As per coding guidelines Also applies to: 15-18 🤖 Prompt for AI Agents |
||
|
|
||
| export const getAllFestivals = (params: PageSizeParams = {}) => | ||
| get<AllFestivalsResponse, PageSizeParams>( | ||
| END_POINT.GET_ALL_FESTIVALS, | ||
| params, | ||
| ); | ||
| get<FestivalsResponse, PageSizeParams>(END_POINT.GET_ALL_FESTIVALS, params); | ||
|
|
||
| export const getPlannedFestivals = (params: PageSizeParams = {}) => | ||
| get<UpcomingFestivalsResponse, PageSizeParams>( | ||
| get<FestivalsResponse, PageSizeParams>( | ||
| END_POINT.GET_PLANNED_FESTIVALS, | ||
| params, | ||
jin-evergreen marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ); | ||
|
|
||
| export const getUpcomingFestival = (params: PageSizeParams = {}) => | ||
| get<UpcomingFestivalResponse, PageSizeParams>( | ||
| get<UpcomingFestivalItem, PageSizeParams>( | ||
| END_POINT.GET_UPCOMING_FESTIVAL, | ||
| params, | ||
| ); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,6 @@ | ||
| export interface MyEventsFestival { | ||
| festivalId: number; | ||
| title: string; | ||
| mainImageUrl: string; | ||
| period: string; | ||
| status: string; | ||
| wishList: boolean; | ||
| } | ||
|
|
||
| export interface MyEventsPagination { | ||
| currentPage: number; | ||
| totalPages: number; | ||
| totalElements: number; | ||
| size: number; | ||
| hasNext: boolean; | ||
| hasPrevious: boolean; | ||
| } | ||
| import type { Festival, PaginationResponse } from './festival'; | ||
|
|
||
| export interface MyEventsResponse { | ||
| festivals: MyEventsFestival[]; | ||
| pagination: MyEventsPagination; | ||
| festivals: Festival[]; | ||
| pagination: PaginationResponse; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,5 @@ | ||
| export interface ViewedFestival { | ||
| festivalId: number; | ||
| title: string; | ||
| mainImageUrl: string; | ||
| period: string; | ||
| status: '관람 중' | '관람 예정' | '관람 완료'; | ||
| wishList: boolean; | ||
| } | ||
|
|
||
| export interface Pagination { | ||
| currentPage: number; | ||
| totalPages: number; | ||
| totalElements: number; | ||
| size: number; | ||
| hasNext: boolean; | ||
| hasPrevious: boolean; | ||
| } | ||
|
|
||
| import type { Festival, PaginationResponse } from './festival'; | ||
| export interface ViewedFestivalsResponse { | ||
| festivals: ViewedFestival[]; | ||
| pagination: Pagination; | ||
| festivals: Festival[]; | ||
| pagination: PaginationResponse; | ||
| } |
Uh oh!
There was an error while loading. Please reload this page.