Conversation
rndnjsgud
reviewed
Mar 26, 2024
There was a problem hiding this comment.
랜덤 변수 생성 메소드와 updatePhase 메소드를 나눠서 개발하면 메소드 길이도 짧아지고, 기능별로 나눌 수 있을 것 같아요
rndnjsgud
reviewed
Mar 26, 2024
rndnjsgud
reviewed
Mar 26, 2024
There was a problem hiding this comment.
클래스 이름은 우승 결과 관련 클래스 같지만 내용은 우승자 점수를 구하는 내용인 것 같아서 클래스 이름을 바꾸거나 기능을 옮겨서 구현하는 편이 좋아 보여요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mvc로 나눠서 만들었고 분리하는 단위를 정하는게 어려워서 다른사람들 코드 참고하면서 작성했습니다. 테스트 코드는 아직 미작성입니다.