Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

adding orderinstructions #58

Merged
merged 6 commits into from
Aug 1, 2024
Merged

adding orderinstructions #58

merged 6 commits into from
Aug 1, 2024

Conversation

jiyoonie9
Copy link
Contributor

@jiyoonie9 jiyoonie9 commented Jul 23, 2024

  • add new order instructions message
  • removed PaymentInstruction fields from quote.payin and quote.payout
  • added tests
  • removed a lot of json.MarshalIndent() used to debug print message creation
  • added json schema for new order instructions message
  • added parse orderinstructions message to be used in tbdex test vector tests
  • bump tbdex spec submodule commit to comply with new tbdex update adding orderinstructions message description  tbdex#355


// ValidNext returns the valid message kinds that can follow an orderinstructions.
func ValidNext() []string {
return []string{closemsg.Kind, cancel.Kind}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an order can't follow an orderinstructions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or an orderstatus?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

order > order instructions > order status is the sequence. will update to add orderstatus to the list here. thanks!

@jiyoonie9 jiyoonie9 merged commit 0687954 into main Aug 1, 2024
2 checks passed
@jiyoonie9 jiyoonie9 deleted the orderinstruction branch August 1, 2024 01:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants