update melonDS to release 1.1 #4562
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Yes, the submodule will need to reference a commit that exists in Line 20 in acfc1f8 otherwise it can't be cloned. |
Member
|
There are more changes that are needed to properly merge 1.1, I'll do the merge myself later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates melonDS to release 1.1. Some info about changes in 1.1 can be found at https://melonds.kuribo64.net/comments.php?id=240.
The particular change I'm interested in right now is the graphics fixes to the OpenGL compute shader renderer. The current version of melonDS in BizHawk does not have a good option for high-resolution rendering as both OpenGL rendering modes contain significant graphical issues. With 1.1, the OpenGL compute looks correct.
The only non-trivial conflicts with the merge were in SPU.cpp and SPU.h. Since upstream now also uses blip buf our changes there shouldn't be necessary anymore. I made those files exactly match the upstream versions. Sound appears to work correctly and does not desync from audio in a 2 minute A/V recording.
The referenced commit for the melonDS submodule is at https://github.com/SuuperW/melonDS/tree/release1.1. I can make a PR for TASEmulator's melonDS fork if desired.