Skip to content

Use a virtualized FlowLayoutPanel for the rcheevos achievments form #4508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Use a virtualized FlowLayoutPanel for the rcheevos achievments form #4508

wants to merge 4 commits into from

Conversation

@Morilli
Copy link
Collaborator

@Morilli Morilli commented Oct 12, 2025 •
edited
Loading

See #4479. Currently WIP and kinda garbage code, not yet sure how to structure this. But it should generally work.

todo:

  • handle form resizing
  • make this implementation less manual and hacky

Check if completed:

@YoshiRulz YoshiRulz added re: RetroAchievements App: EmuHawk Relating to EmuHawk frontend labels Oct 12, 2025
@Morilli Morilli marked this pull request as ready for review October 16, 2025 06:48
@YoshiRulz YoshiRulz linked an issue Oct 16, 2025 that may be closed by this pull request
Refactor RCheevosAchievementListForm and RCheevosLeaderboardListForm to not use a separate form for each respective item #4479
Open
CasualPokePlayer
CasualPokePlayer reviewed Oct 23, 2025
View reviewed changes
@Morilli
use a virtualized FlowLayoutPanel for the rcheevos achievments form
81b9055 
some logic fixes

remove updateCooldown variable

implement resizing
@Morilli
move more logic into virtual FLP class
17706ff
@Morilli
move class into its own file
8be6512 
some questionable nullable annotations whatever
@Morilli
Copy link
Collaborator Author

Morilli commented Nov 18, 2025 •
edited
Loading

By the way this is about ready from my side. I'm still not too happy with the code structure but it works and fixes the issue, so 🤷.

Unless there's complaints I'd like to merge this soon so we have a working achievements and leaderboards form for the next release.

Edit: Seems to crash in my wsl ubuntu because OnSizeChanged is called during InitializeComponent... sigh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CasualPokePlayer CasualPokePlayer Awaiting requested review from CasualPokePlayer

Assignees

No one assigned

Labels

App: EmuHawk Relating to EmuHawk frontend re: RetroAchievements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor RCheevosAchievementListForm and RCheevosLeaderboardListForm to not use a separate form for each respective item

3 participants

@Morilli @CasualPokePlayer @YoshiRulz