PMSBuildTasks/{Props,Targets} - apply versions to intermediate or intermediate and source #6
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomProkop
requested changes
Nov 13, 2024
| <OptionSets Include="$(DataverseSolutionSourceFolderFullPath)\OptionSets\**\*.xml"/> | ||
| <SavedQueries Include="$(DataverseSolutionSourceFolderFullPath)\Entities\*\SavedQueries\*.xml" /> | ||
| <WorkflowMetadata Include="$(DataverseSolutionSourceFolderFullPath)\Workflows\*.xaml"/> | ||
| <WorkflowMetadata Include="$(DataverseSolutionSourceFolderFullPath)\Workflows\**\*.xaml"/> |
There was a problem hiding this comment.
Is this nesting supported by the solution packager?
| <PluginAssemblyMetadataFilesIntermediateOutputPath Include="$(SolutionPackagerMetadataWorkingDirectory)\PluginAssemblies\**\*.dll.data.xml"/> | ||
| <WorkflowMetadataIntermediateOutputPath Include="$(SolutionPackagerMetadataWorkingDirectory)\Workflows\**\*.xaml"/> | ||
| <SdkMessageProcessingStepsIntermediateOutputPath Include="$(SolutionPackagerMetadataWorkingDirectory)\SdkMessageProcessingSteps\*.xml"/> | ||
| <CustomControlsIntermediateOutputPath Include="$(SolutionPackagerMetadataWorkingDirectory)\CustomControls"/> |
There was a problem hiding this comment.
I think the folder is called Controls
There was a problem hiding this comment.
Removed the unused Item. HAJ solved it like this:
| <Message Text="Updating version to $(Version) in all references..." Importance="high" /> | ||
| <ApplyVersionNumber Version="$(Version)" SolutionXml="%(SolutionXml.FullPath)" PluginAssemblies="@(PluginAssemblies)" Workflows="@(WorkflowMetadata)" SdkMessageProcessingSteps="@(SdkMessageProcessingSteps)" CustomControlsFolder="$(SolutionPackagerMetadataWorkingDirectory)" /> | ||
| <ApplyVersionNumber Version="$(Version)" SolutionXml="%(SolutionXmlIntermediateOutputPath.FullPath)" PluginAssemblies="@(PluginAssemblyMetadataFilesIntermediateOutputPath)" Workflows="@(WorkflowMetadataIntermediateOutputPath)" SdkMessageProcessingSteps="@(SdkMessageProcessingStepsIntermediateOutputPath)" CustomControlsFolder="$(SolutionPackagerMetadataWorkingDirectory)" /> | ||
| <ApplyVersionNumber Condition="'$(ApplyVersionNumberToSource)' == 'true'" Version="$(Version)" SolutionXml="%(SolutionXml.FullPath)" PluginAssemblies="@(PluginAssemblyMetadataFiles)" Workflows="@(WorkflowMetadata)" SdkMessageProcessingSteps="@(SdkMessageProcessingSteps)" /> |
There was a problem hiding this comment.
I think Controls can also be present in the source for some people
There was a problem hiding this comment.
See HAJ's solution from comment above
|
We are not merging this PR since #7 does most of the work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.