Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add digital_dataset and description fields to DrpOriginDatasetMetadata #1067

Merged

Conversation

van-go
Copy link
Contributor

@van-go van-go commented Feb 26, 2025

Overview

Requested Changes [post-workshop] for the "Add Digital Dataset" View

Related

Changes

  • Replace the label “Base Sample” with “Reference Sample”.

Add a list of descriptions for each field that needs to be populated:

  • Descriptions for the digital dataset fields: A note to the opening page: “Digital datasets should not contain any analysis results. If any kind of analysis is conducted on the dataset and is included in the data, it should be listed under the analysis dataset (see next section).”

  • Reference Sample: “The corresponding sample for this digital dataset.”

  • If the “Source” of the reference sample is not computer generated, the following information is required.

  • Imaging Center: “The place where the sample was imaged.”

  • Imaging Equipment: “The name and the model of the imaging equipment.”

  • Image Format: “The image format (*.tiff, *.raw, etc…)”

  • Image Dimensions and Byte Order: “Length, width, and height of the image along with the byte order (not necessary if the image format is *.tiff)”

  • Dimensionality: “Whether the data is 2D, 3D, 4D, or other.”

  • Reference Digital Dataset: “The DOI or URI of an existing public dataset from DPMP or another repository that is used to generate the digital dataset.” THIS IS A NEW FIELD

  • Other Information: “Information that the authors find relevant to the digital dataset, such as the mineral and fluid phases in it, labels for segmentation if it is segmented, etc.” THIS FIELD REPLACES DESC

Testing

UI

Screen Shot 2025-02-26 at 12 43 48 PM

Notes

I was unable to do the first description request. (Digital datasets should not contain any analysis results. If any kind of analysis is conducted on the dataset and is included in the data, it should be listed under the analysis dataset (see next section).)

@van-go van-go requested review from taoteg and shayanaijaz February 26, 2025 18:50
@shayanaijaz shayanaijaz merged commit f1e6001 into task/digital-rocks Mar 4, 2025
0 of 4 checks passed
@shayanaijaz shayanaijaz deleted the task/wc-195-Add-Digital-Dataset-view branch March 4, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants