WP-519: APCD Custom getting started page - more standard & compatible #282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Overwrite template, instead of creating a new one, so that settings need not be updated.*
What is wrong with updating the setting?
Such a settings update in my experience has not been backwards-compatible (prod page will break upon deploy) nor future-compatible (not using a custom template in future, prod page will break upon deploy).
Fail Case
Deploy project
Open existing page that uses "Guide: Getting Started" template.
Notice page crash…
(unless someone updated page after deploy via
/admin
UI to use guide template setting path "A" before visiting the page)Related
Changes
added text to distinguish template from the Core-CMS one it overwrites
Testing
Local
/apcd-cms/src/taccsite_cms/settings_custom.py
with pre–WP-519 settings.Remote
/admin
change template to original template path.UI