-
Notifications
You must be signed in to change notification settings - Fork 37
Add betting functionality #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matteomekhail
wants to merge
5
commits into
T3-Content:main
Choose a base branch
from
matteomekhail:betting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
674af82
Add betting functionality with user management and betting tables
matteomekhail a7cfbf9
implemented macroscope suggestion
matteomekhail 7988588
Implemented coderabbit suggestion
matteomekhail 5e8b17e
Implemented coderabbit suggestion pt2
matteomekhail e12d4ce
merge origin/main, resolve conflicts
matteomekhail File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Client-controlled UUID used as sole authentication.
The client generates the user ID (
crypto.randomUUID()in frontend.tsx Line 129) and the server trusts it for all subsequent operations (/api/bet,/api/me). While UUIDs are hard to brute-force, the ID is transmitted as a query parameter in/api/me?id=..., exposing it in browser history, server logs, and referrer headers. Anyone with access to the ID can impersonate the user.For a virtual-currency game this is likely acceptable, but worth noting if the system ever handles anything of value. A server-generated opaque session token (e.g., via
Set-Cookie: HttpOnly) would be more robust.🤖 Prompt for AI Agents