Skip to content

fix(security): prevent path traversal in /assets/ endpoint #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JulesB40 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −2
Open

fix(security): prevent path traversal in /assets/ endpoint #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { ServerWebSocket } from "bun";
import { timingSafeEqual } from "node:crypto";
import { resolve, relative } from "node:path";
import indexHtml from "./index.html";
import historyHtml from "./history.html";
import adminHtml from "./admin.html";
Expand Down Expand Up @@ -115,6 +116,7 @@ const VIEWER_VOTE_BROADCAST_DEBOUNCE_MS = parsePositiveInt(
);
const ADMIN_COOKIE = "quipslop_admin";
const ADMIN_COOKIE_MAX_AGE_SECONDS = 60 * 60 * 24 * 30;
const PUBLIC_DIR = resolve("./public");

const requestWindows = new Map<string, number[]>();
const wsByIp = new Map<string, number>();
Expand Down Expand Up @@ -423,8 +425,16 @@ const server = Bun.serve<WsData>({
const ip = getClientIp(req, server);

if (url.pathname.startsWith("/assets/")) {
const path = `./public${url.pathname}`;
const file = Bun.file(path);
const assetPath = url.pathname.slice(8);
if (!assetPath) {
return new Response("Not found", { status: 404 });
}
const resolved = resolve(PUBLIC_DIR, assetPath);
const relativePath = relative(PUBLIC_DIR, resolved);
if (relativePath.startsWith("..") || relativePath === "..") {
return new Response("Forbidden", { status: 403 });
}
const file = Bun.file(resolved);
return new Response(file, {
headers: {
"Cache-Control": "public, max-age=604800, immutable",
Expand Down