Feature/security - #19
Merged
Merged
Conversation
- EC2 needs KMS permissions in its IAM role when mounting an encrypted volume for the first time - KMS key policy also needs to grant permissions to the resources that will use the key - It's a two-way setup: IAM role must allow using the KMS key, and the KMS key must also allow the IAM role - ASG instances created from the Launch Template need KMS permissions to create encrypted EBS volumes
- Removing $ from RDS password generation - Resolves 'unbound variable' error that caused script execution to fail"
- Create Route 53 A record pointing dev.isaactai13.me to ALB for DNS resolution - Bind ACM certificate (dev.isaactai13.me) to ALB HTTPS listener to enable SSL/TLS encryption - Change from wildcard certificate to bare domain certificate for proper domain matching"
Add missing KMS policy for secrets_key to allow Lambda role to decrypt Mailgun API key from Secrets Manager. Also enhance IAM permissions with DescribeSecret and DescribeKey actions.
- If demo_certificate_arn is provided, then it's using https cert for demo account
- Using variable for db table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.