Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @Syxton,
I've identified an issue where the sketch modal appears squashed after using the record video feature. Here's how to reproduce it:
Navigate to a forum and create a new post (or any content using TinyMCE with RecordRTC plugin)
Click the Sketch icon - note that the sketch editor appears in full size
Close the modal
Click the record video button, make a recording and attach it
Click Sketch again - you'll notice the modal is now squashed vertically
You can see this behavior in the video here:
https://github.com/user-attachments/assets/ff133cb3-2105-45d9-bb13-1e61398b941a
Root cause: The issue occurs because
document.querySelector('.modal-dialog')can't identify the correct modal when a second one is opened.I've submitted a PR to fix this issue. Please review and merge when possible.