Skip to content

add buttons format #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Syxton wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add buttons format #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98ffd73
add buttons format
Syxton Apr 21, 2022
af1033f
Update upgrade.php
Syxton Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions db/upgrade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ function xmldb_block_massaction_upgrade($oldversion, $block): bool {
upgrade_block_savepoint(true, 2022000000, 'massaction', false);
}

if ($oldversion < 2022042001) { // Add buttons support.
block_massaction_add_supported_format('buttons');
upgrade_block_savepoint(true, 2022042001, 'massaction', false);
}

return true;
}

Expand Down
2 changes: 1 addition & 1 deletion settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
});

// These are the formats supported by the maintainer.
$supportedformatsbydefault = ['weeks' => 1, 'topics' => 1, 'topcoll' => 1];
$supportedformatsbydefault = ['weeks' => 1, 'topics' => 1, 'topcoll' => 1, 'buttons' => 1];

$settings->add(new admin_setting_configmulticheckbox(
'block_massaction/applicablecourseformats',
Expand Down
74 changes: 74 additions & 0 deletions tests/behat/buttons.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
@block @block_massaction @block_massaction_buttons
Feature: Check if block generates all necessary checkboxes in buttons format and properly disables
the currently not active sections (or sections not containing any modules)

@javascript
Scenario: Check if checkboxes are created properly for buttons format
Given I installed course format "buttons"
And the following "courses" exist:
| fullname | shortname | numsections | format |
| Test course | TC | 5 | buttons |
And the following "users" exist:
| username | firstname | lastname | email |
| teacher1 | Mr | Teacher | [email protected] |
And the following "course enrolments" exist:
| user | course | role |
| teacher1 | TC | editingteacher |
And the following "activities" exist:
| activity | course | idnumber | name | intro | section |
| page | TC | 1 | Test Activity1 | Test page description | 0 |
| page | TC | 2 | Test Activity2 | Test page description | 1 |
| label | TC | 3 | Test Activity3 | Label text | 2 |
| page | TC | 4 | Test Activity4 | Test page description | 4 |
| page | TC | 5 | Test Activity5 | Test page description | 4 |
When I log in as "teacher1"
And I am on "Test course" course homepage with editing mode on
And I add the "Mass Actions" block
And I click on "Test Activity1 Checkbox" "checkbox"
And I click on "Test Activity4 Checkbox" "checkbox"
Then the field "Test Activity1 Checkbox" matches value "1"
Then the field "Test Activity2 Checkbox" matches value ""
Then the field "Label text Checkbox" matches value ""
Then the field "Test Activity4 Checkbox" matches value "1"
Then the field "Test Activity5 Checkbox" matches value ""
Then the "disabled" attribute of "#block-massaction-control-section-list-select-option-0" "css_element" should not be set
Then the "disabled" attribute of "#block-massaction-control-section-list-select-option-1" "css_element" should not be set
Then the "disabled" attribute of "#block-massaction-control-section-list-select-option-2" "css_element" should not be set
Then the "disabled" attribute of "#block-massaction-control-section-list-select-option-3" "css_element" should be set
Then the "disabled" attribute of "#block-massaction-control-section-list-select-option-4" "css_element" should not be set

@javascript
Scenario: Check if mass actions 'indent' and 'outdent' work
# We need to use a different course format which supports indentation.
# From moodle 4.0 on this is a feature a course format has to explicitely support.
Given I installed course format "buttons"
And the following "courses" exist:
| fullname | shortname | numsections | format |
| Test course | TC2 | 5 | buttons |
And the following "users" exist:
| username | firstname | lastname | email |
| teacher1 | Mr | Teacher | [email protected] |
And the following "course enrolments" exist:
| user | course | role |
| teacher1 | TC2 | editingteacher |
And the following "activities" exist:
| activity | course | idnumber | name | intro | section |
| page | TC2 | 1 | Test Activity1 | Test page description | 0 |
| page | TC2 | 2 | Test Activity2 | Test page description | 1 |
| label | TC2 | 3 | Test Activity3 | Label text | 2 |
| page | TC2 | 4 | Test Activity4 | Test page description | 4 |
| assign | TC2 | 5 | Test Activity5 | Test page description | 4 |
When I log in as "teacher1"
And I am on "Test course" course homepage with editing mode on
And I add the "Mass Actions" block
# Everything is setup now, let's do the real test.
And I click on "Test Activity2 Checkbox" "checkbox"
And I click on "Test Activity5 Checkbox" "checkbox"
And I click on "Indent (move right)" "link" in the "Mass Actions" "block"
Then "#section-1 li.modtype_page div.indent-1" "css_element" should exist
Then "#section-4 li.modtype_assign div.indent-1" "css_element" should exist
When I click on "Test Activity2 Checkbox" "checkbox"
And I click on "Test Activity5 Checkbox" "checkbox"
And I click on "Outdent (move left)" "link" in the "Mass Actions" "block"
Then "#section-1 li.modtype_page div.indent-1" "css_element" should not exist
Then "#section-4 li.modtype_assign div.indent-1" "css_element" should not exist
2 changes: 1 addition & 1 deletion version.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

defined('MOODLE_INTERNAL') || die;

$plugin->version = 2022042000;
$plugin->version = 2022042001;
$plugin->requires = 2022041900;
$plugin->component = 'block_massaction';
$plugin->maturity = MATURITY_STABLE;
Expand Down