Conversation
…orks/dirty_thirties into exercise7
Contributor
|
Hi! I see you followed @roschaefer advice in aiming for the quick points. ⭐ For Lighthouse reporting that your production website is installable as PWA (except HTTPS). That makes 4 ⭐ in total. As you did this alone, this means full points for you @SarahLM . See you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finished:
⭐ For instructions in the
README.mdon how to build your webappfor production.
⭐ For no changes in "Files Changed" tab of the refactoring from
vue-clitocreate-nuxt-app. (See #1 in instructions)⭐ For
Lighthouse
reporting that your production website is installable as PWA (except
HTTPS).
⭐ For requesting a review and reviewing another team's PR.
Lighthouse result:
Link to review:
Systems-Development-and-Frameworks/no-js-pls#9 (review)