Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ariang] Add package #5860

Merged
merged 2 commits into from
Apr 6, 2024
Merged

[ariang] Add package #5860

merged 2 commits into from
Apr 6, 2024

Conversation

vitkabele
Copy link
Contributor

@vitkabele vitkabele commented Aug 28, 2023

Description

Hello,
now that I learned how to create packages in the #5837, I spent an evening on creating an ariang package for easy installation of the web frontend for the already existing aria2 package.

Compared to the #5837 it is really simple so I believe it should be also easier to review.

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

cross/ariang/PLIST Outdated Show resolved Hide resolved
@hgy59

This comment was marked as outdated.

@hgy59
Copy link
Contributor

hgy59 commented Aug 29, 2023

@vitkabele sorry for my comment of ignorance (now hidden)

This package is full of javascript and the downloadable release is already built with npm.

The comment regarding aria2 packaging remains:

we have aria2c in the synocli-net package, so this package would depend on it.
BUT I propose to remove aria2c there and include it here, to get a standalone aria2 package. (i.e. we would not build an ariang package but call it aria2 and include cross/aria2 and cross/ariang).

The original idea was to create an aria2 package with a web UI, but the UI was not available (or nobody had time to add it, or make it work) so we finally added the command line version (aria2c) to synocli-net.
But with a working web UI it is time to clean this up.

@vitkabele
Copy link
Contributor Author

Yeah, I went through the aria2 related tickets. I agree that it would be nice to have separate aria2 package. It could provide STARTABLE service. It shouldn't be much work. I will take a look at that and eventually resolve all the related tickets by creating the new package.

I saw that one can create app/config with desktop icon for the DSM web UI. All my attempts to make this working however only lead to the ariang being opened in a new browser tab. Is there a way how to open the ariang in a "window" so that we could get similar experience to a Download Station and other DSM apps?

Btw I did not found what is the difference between spk and diyspk directories? Is it that the diyspk is not published to the repository?

@hgy59
Copy link
Contributor

hgy59 commented Aug 29, 2023

Btw I did not found what is the difference between spk and diyspk directories? Is it that the diyspk is not published to the repository?

diyspk are "do it yourself spk" and are intended to build packages for tools that are included in synocli-packages. Often the synocli packages need a lot of build time. When you are updating a single tool of a cli package (or create a new tool for) you don't want to waste time with building the whole packages.

Some diyspk packages even have icons, that where kept, when a former dedicated package was integrated into a synocli package.

@hgy59
Copy link
Contributor

hgy59 commented Aug 29, 2023

I saw that one can create app/config with desktop icon for the DSM web UI. All my attempts to make this working however only lead to the ariang being opened in a new browser tab. Is there a way how to open the ariang in a "window" so that we could get similar experience to a Download Station and other DSM apps?

The app config files in the package should be created by our framework (as soon as you have a startable service).

You will not be able to integrate a web app into the DSM UI (this would require to integrate it as ExtJs app/extension into the DSM framework).

This finally does not work for existing web apps.
If you want to create such an app from scratch, there are some new attempts in #5768 and #4568

This would be useful for limitted configuration dialogs. We had packages with such an approach but one of the main components (pyextdirect) was never ported to python3.

@hgy59 hgy59 added the new-package PR/WIP for a new package label Jan 19, 2024
spk/ariang/Makefile Outdated Show resolved Hide resolved
spk/ariang/Makefile Outdated Show resolved Hide resolved
spk/ariang/Makefile Outdated Show resolved Hide resolved
- update ariang to v1.3.7
- adjust PLIST to make it independent of version
- use larger icon
@hgy59
Copy link
Contributor

hgy59 commented Apr 6, 2024

@vitkabele thanks for your work. I know it was a long time open, ...

I will merge this PR soon, but not publish the package until the aria2 package is updated, fixed and published.
When aria2 package is working, the ariang package will depend on it (add aria2 to SPK_DEPENDS) and then aria2 and ariang can be published.

@hgy59 hgy59 merged commit 9eb5f41 into SynoCommunity:master Apr 6, 2024
17 checks passed
@hgy59 hgy59 added the status/published Published and activated (may take up to 48h until visible in DSM package manager) label Apr 7, 2024
@hgy59
Copy link
Contributor

hgy59 commented Apr 7, 2024

Just published this package.
No need to make it dependent of aria2 package, since it can be used with any aria2 server. It is not restricted to local aria2 package installation.

Package aria2 is on the way in #6068

@mreid-tt mreid-tt mentioned this pull request Jun 10, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package PR/WIP for a new package status/published Published and activated (may take up to 48h until visible in DSM package manager)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants