Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cops: upgrade php + fix OOM when downloading big files #5653

Closed

Conversation

smaarn
Copy link
Contributor

@smaarn smaarn commented Mar 3, 2023

Description

  • Upgrade PHP version being used from 7.2 to 7.4 (7.2 version is no longer available from Synology package lists)
  • Fix OOM when fetching big files.
  • Reworked wizards to simplify maintenance (using mustache)
  • Fix icon display in DSM 7
  • Fix online viewer

This MR also depends and includes #5819 which allows for simplification of templates IMHO.

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested

Type of change

  • Bug fix

@smaarn smaarn requested a review from Diaoul March 3, 2023 21:35
@smaarn smaarn force-pushed the feat/cops/upgrade-php-fix-oom branch from 6988e8f to f7cd94f Compare May 6, 2023 17:12
@smaarn smaarn force-pushed the feat/cops/upgrade-php-fix-oom branch from f7cd94f to 59a6d9f Compare August 6, 2023 22:13
@smaarn smaarn requested a review from hgy59 August 6, 2023 22:16
@hgy59
Copy link
Contributor

hgy59 commented Aug 7, 2023

@smaarn do we need this intermedeate package version or can we drop this PR and go further with #5817?

@smaarn
Copy link
Contributor Author

smaarn commented Aug 7, 2023

@smaarn do we need this intermedeate package version or can we drop this PR and go further with #5817?

@hgy59 I think we have no choice but to go with this PR to fix current version and have the other MR done separately to keep a DSM 6 version functional.

At least from what I understood with the PHP 8 requirement starting from version 1.2.0

@smaarn
Copy link
Contributor Author

smaarn commented Aug 7, 2023

@smaarn do we need this intermedeate package version or can we drop this PR and go further with #5817?

@hgy59 I think we have no choice but to go with this PR to fix current version and have the other MR done separately to keep a DSM 6 version functional.

At least from what I understood with the PHP 8 requirement starting from version 1.2.0

Just saw your comment on the "other" MR. Will be flagging this MR as draft and rework the latter.

@smaarn smaarn closed this Aug 7, 2023
@smaarn smaarn deleted the feat/cops/upgrade-php-fix-oom branch August 30, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants