limited implementation of group by / aggregates + bumped dependency revs #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[like] Don Fillion reacted to your message:
…________________________________
From: Ben Lieber ***@***.***>
Sent: Friday, October 24, 2025 3:21:39 PM
To: Synergex/HarmonyCore ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [EXTERNAL] Re: [Synergex/HarmonyCore] limited implementation of group by / aggregates + bumped dependency revs (PR #389)
@blieber1 approved this pull request.
Looks good to me! 👍
—
Reply to this email directly, view it on GitHub<#389 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BM47V6ZAHDHAUCFICLMXKUD3ZI7YHAVCNFSM6AAAAACKCF3L4KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGNZXGQ3TKMZTGI>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
CAUTION: This email originated from outside of Synergex. Please do not click links or open attachments from an unknown or suspicious sender.
|
|
Even though this isn't considered core OData functionality, it seems like a no brainer as it unlocks powerful query capabilities for Harmony integrations. Thank you for adding this. 🙌 |
|
@hippiehunter Any ETA of when this will get merged and deployed? |
|
sometime this week |
|
This looks like GroupBy was added in this PR and we are excited to try this out. Are there plans to also add Sum, Avg, Min and Max? Those are the 4 aggregators that we would need for most use cases. |
|
this includes a test for sum, but it wasnt specifically coded for sum. It should cover the full range of standard mathy aggregate functions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds limited support for aggregate odata operations. This is incomplete and requires CLI tool changes to deal with an added dependency. It turns out the stock OData libraries cant serialize an aggregate response and we have to add a newtonsoft json helper library and call to set that up instead of the existing call to configure newtonsoft json during mvc startup.