test: add coverage for asset events, mark_failed event order, and non-admin pause/unpause (#595 #596 #600 #607)#629
Open
ooochoche wants to merge 3 commits intoSynapse-bridgez:developfrom
Open
test: add coverage for asset events, mark_failed event order, and non-admin pause/unpause (#595 #596 #600 #607)#629ooochoche wants to merge 3 commits intoSynapse-bridgez:developfrom
ooochoche wants to merge 3 commits intoSynapse-bridgez:developfrom
Conversation
|
@ooochoche Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Closes #595
Closes #596
Closes #600
Closes #607
Summary
Adds missing contract tests for event emission and admin access control in contract_test.rs.
What changed
test_add_asset_emits_eventEvent::AssetAdded(asset_code)is the last emitted event afteradd_asset.test_remove_asset_emits_eventEvent::AssetRemoved(asset_code)is the last emitted event afterremove_asset.test_mark_failed_emits_eventsmark_failedare:Event::StatusUpdated(...)Event::MovedToDlq(tx_id, error_reason)test_non_admin_cannot_pause#[should_panic(expected = "not admin")]test_non_admin_cannot_unpause#[should_panic(expected = "not admin")]Why
AssetAddedpayloadAssetRemovedpayloadmark_failedevent sequence and payloadpauseandunpauseTesting