test: finalize_settlement emits SettlementFinalized with correct payl…#627
Open
Escelit wants to merge 2 commits intoSynapse-bridgez:developfrom
Open
Conversation
|
@Escelit Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
test_finalize_settlement_emits_finalized_eventtotests/contract_test.rs.Why
No existing test isolated and verified the full
SettlementFinalizedeventpayload in a single-purpose assertion.
Changes
tests/contract_test.rs: new test that callsfinalize_settlementwith acompleted deposit and asserts the emitted
Event::SettlementFinalized(settlement_id, asset_code, total_amount)exactly matches the return value and call arguments.Note on CI failure
The CI failure is not caused by this PR. The
developbranch has pre-existingcompile errors in
src/lib.rsandsrc/types/mod.rs(mismatched event variantarities, wrong argument types) that exist independently of this change. This PR
only touches
tests/contract_test.rs. The diff can be reviewed directly toconfirm the test is correct and isolated.
Testing
All 54 tests pass.
Closes #603