Skip to content

Fix some syntax errors #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
leonschoorl wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix some syntax errors #45

leonschoorl wants to merge 3 commits into from

Conversation

@leonschoorl
Copy link

@leonschoorl leonschoorl commented Jan 26, 2021

I tried to follow the Quick Start Guide, but I ran into some syntax errors with the current version of yosys (8eaeaa84346):

[pc_fwd_ch0] base: rvfi_pc_fwd_check.sv:19: ERROR: syntax error, unexpected TOK_RAND
[causal_ch0] base: rvfi_causal_check.sv:19: ERROR: syntax error, unexpected TOK_RAND
[liveness_ch0] base: rvfi_liveness_check.sv:19: ERROR: syntax error, unexpected TOK_RAND
[reg_ch0] base: rvfi_reg_check.sv:19: ERROR: syntax error, unexpected TOK_RAND
[unique_ch0] base: rvfi_unique_check.sv:19: ERROR: syntax error, unexpected TOK_RAND
[pc_bwd_ch0] base: rvfi_pc_bwd_check.sv:19: ERROR: syntax error, unexpected TOK_RAND
[csrw_mcycle_ch0] base: rvfi_csrw_check.sv:56: ERROR: syntax error, unexpected TOK_ID
[csrw_minstret_ch0] base: rvfi_csrw_check.sv:56: ERROR: syntax error, unexpected TOK_ID

After these patches I'm still left with the same PREUNSAT errors as #36.

@leonschoorl
Switch "const" and "rand" modifier order
96ddaa0 
The current Yosys only accepts the order: rand const
The other way round results in:
	ERROR: syntax error, unexpected TOK_RAND

And "rand const" is also the way they show it in their README:
https://github.com/YosysHQ/yosys/blob/master/README.md#non-standard-or-systemverilog-features-for-formal-verification
@leonschoorl
Rename macro rvformal_const_rand_reg to rvformal_rand_const_reg
0a29531 
So it matches the new order of the modifiers
@leonschoorl
Fix syntax errors in rvfi_csrw_check.sv
e0fd8ce 
	`csrget(`RISCV_FORMAL_CSRW_NAME, rmask)
Got expanded into:
	rvfi.csr_mcycle_ rmask

Because of the extra space, this resulted in:
	[csrw_mcycle_ch0] base: rvfi_csrw_check.sv:56:
		ERROR: syntax error, unexpected TOK_ID
@dopamane dopamane mentioned this pull request Mar 11, 2021
Closed
@silabs-robin silabs-robin mentioned this pull request Sep 7, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@leonschoorl