Skip to content

RefundPayment - Payment relation #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartoszpietrzak1994 merged 3 commits into from
Oct 12, 2018
Merged

RefundPayment - Payment relation #85

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cac8283
Related payment id in RefundPaymentGenerated event
Zales0123 Oct 2, 2018
856685b
Default service for getting related payment id for refund payment
Zales0123 Oct 2, 2018
23ea93f
Use related payment id provider during refund payment generation
Zales0123 Oct 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion spec/Event/RefundPaymentGeneratedSpec.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,13 @@ final class RefundPaymentGeneratedSpec extends ObjectBehavior
{
function it_represents_an_immutable_fact_that_refund_payment_has_been_generated(): void
{
$this->beConstructedWith(1, '000222', 10000, 'GBP', 2);
$this->beConstructedWith(1, '000222', 10000, 'GBP', 2, 3);

$this->id()->shouldReturn(1);
$this->orderNumber()->shouldReturn('000222');
$this->amount()->shouldReturn(10000);
$this->currencyCode()->shouldReturn('GBP');
$this->paymentMethodId()->shouldReturn(2);
$this->paymentId()->shouldReturn(3);
}
}
19 changes: 17 additions & 2 deletions src/Event/RefundPaymentGenerated.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,23 @@ final class RefundPaymentGenerated
/** @var int */
private $paymentMethodId;

public function __construct(int $id, string $orderNumber, int $amount, string $currencyCode, int $paymentMethodId)
{
/** @var int */
private $paymentId;

public function __construct(
int $id,
string $orderNumber,
int $amount,
string $currencyCode,
int $paymentMethodId,
int $paymentId
) {
$this->id = $id;
$this->orderNumber = $orderNumber;
$this->amount = $amount;
$this->currencyCode = $currencyCode;
$this->paymentMethodId = $paymentMethodId;
$this->paymentId = $paymentId;
}

public function id(): int
Expand All @@ -54,4 +64,9 @@ public function paymentMethodId(): int
{
return $this->paymentMethodId;
}

public function paymentId(): int
{
return $this->paymentId;
}
}
3 changes: 2 additions & 1 deletion src/ProcessManager/RefundPaymentProcessManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ public function __invoke(UnitsRefunded $event): void
$event->orderNumber(),
$event->amount(),
$event->currencyCode(),
$event->paymentMethodId()
$event->paymentMethodId(),
1
Copy link
Copy Markdown

@peterukena peterukena Oct 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this is currently hardcoded like this to support single-payment orders?

));

$this->orderFullyRefundedStateResolver->resolve($event->orderNumber());
Expand Down