Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not really a "direct" bug fix but more of a "indirect" bug fix, if we can call it like that 😅
Btw, this change is necessary when the Payment Method form of the admin is tagged as a
sylius.live_component.admininstead of the defaultsylius.component.admin, like the Shipment Method form for example. You want to do this for example if you have a customization where you can configure some fees for each channel, and to do this you have to make it a Live component.Sadly, out of the box, this will throw an error 'cause when the Live component re-renders it creates and empty Payment Method that has no gateway config and it pass from the PRE_SET_DATA of this extension and fails.
I know that is due to the fact that we made the payment method a live component with a customization, but it's probably something that this plugin should handle out of the box. What do you think?