This PR enables SSR support #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Swizec - Can we please get this merge in? |
timohermans
reviewed
May 15, 2020
src/index.ts
Outdated
| }: UseDimensionsArgs = {}): UseDimensionsHook { | ||
| const [dimensions, setDimensions] = useState({}); | ||
| const [node, setNode] = useState(null); | ||
|
|
||
| const useLayoutHookBasedOnEnvironment = typeof window === undefined ? useEffect : useLayoutEffect; |
There was a problem hiding this comment.
I just wanted to let you know this code won't work, because typeof will always return a string. This works:
typeof window === "undefined" [...]
There was a problem hiding this comment.
Oh. My bad. Fixed it. Thanks
There was a problem hiding this comment.
Agree this would be nice to get merged.
Closed
ahmedu007
approved these changes
Nov 3, 2020
|
Any news on this getting merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing a flag named enableSSR and use useEffect instead of useLayoutEffect when enableSSR is true.
Referred gist - https://gist.github.com/gaearon/e7d97cdf38a2907924ea12e4ebdf3c85
Related issue:
#27 (comment)