Skip to content

refactor: add custom ULID type for sqlalchemy #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

Panaetius
Copy link
Member

@Panaetius Panaetius commented Aug 8, 2024

this allows us to have ULID on ORMs. In the DB it will still be a string
/deploy

@Panaetius
Copy link
Member Author

Panaetius commented Aug 8, 2024

Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

leafty
leafty previously approved these changes Aug 9, 2024
@Panaetius Panaetius force-pushed the refactor/304-add-validation-to-projects branch from 340974f to c5c79ac Compare August 12, 2024 09:44
@Panaetius Panaetius force-pushed the refactor/304-add-ulid-sqlalchemy branch from c42f324 to cd53826 Compare August 12, 2024 09:45
@Panaetius Panaetius changed the base branch from refactor/304-add-validation-to-projects to main August 12, 2024 14:13
@Panaetius Panaetius dismissed leafty’s stale review August 12, 2024 14:13

The base branch was changed.

@Panaetius Panaetius force-pushed the refactor/304-add-ulid-sqlalchemy branch from cd53826 to 9640498 Compare August 12, 2024 14:13
@Panaetius Panaetius requested a review from leafty August 12, 2024 14:14
olevski
olevski previously approved these changes Aug 12, 2024
@Panaetius Panaetius force-pushed the refactor/304-add-ulid-sqlalchemy branch from 9640498 to a4ee522 Compare August 12, 2024 14:40
@olevski olevski self-requested a review August 12, 2024 14:49
olevski
olevski previously approved these changes Aug 12, 2024
@coveralls
Copy link

coveralls commented Aug 13, 2024

Pull Request Test Coverage Report for Build 10490359484

Details

  • 158 of 159 (99.37%) changed or added relevant lines in 34 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.05%) to 90.485%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/authz/authz.py 25 26 96.15%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/connected_services/blueprints.py 1 98.17%
components/renku_data_services/connected_services/db.py 7 82.67%
Totals Coverage Status
Change from base Build 10486788022: 0.05%
Covered Lines: 9263
Relevant Lines: 10237

💛 - Coveralls

@Panaetius
Copy link
Member Author

I reworked this a bit and combined this PR with #348

@Panaetius Panaetius force-pushed the refactor/304-add-ulid-sqlalchemy branch 4 times, most recently from 90b6fc8 to b027a94 Compare August 20, 2024 09:25
@Panaetius Panaetius requested a review from olevski August 20, 2024 11:41
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ds-346.dev.renku.ch

@Panaetius Panaetius force-pushed the refactor/304-add-ulid-sqlalchemy branch from b027a94 to 1505e3d Compare August 21, 2024 10:20
olevski
olevski previously approved these changes Aug 21, 2024
@Panaetius Panaetius merged commit e509bd8 into main Aug 21, 2024
16 checks passed
@Panaetius Panaetius deleted the refactor/304-add-ulid-sqlalchemy branch August 21, 2024 13:34
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants