-
Notifications
You must be signed in to change notification settings - Fork 2
refactor: add custom ULID type for sqlalchemy #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is part of the following stack: Change managed by git-spice. |
This was referenced Aug 8, 2024
6eb4d3b
to
5a6e53e
Compare
leafty
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
leafty
previously approved these changes
Aug 9, 2024
340974f
to
c5c79ac
Compare
c42f324
to
cd53826
Compare
cd53826
to
9640498
Compare
olevski
previously approved these changes
Aug 12, 2024
9640498
to
a4ee522
Compare
olevski
previously approved these changes
Aug 12, 2024
97219e4
to
dab2f8e
Compare
Pull Request Test Coverage Report for Build 10490359484Details
💛 - Coveralls |
I reworked this a bit and combined this PR with #348 |
90b6fc8
to
b027a94
Compare
You can access the deployment of this PR at https://renku-ci-ds-346.dev.renku.ch |
b027a94
to
1505e3d
Compare
olevski
previously approved these changes
Aug 21, 2024
olevski
approved these changes
Aug 21, 2024
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows us to have ULID on ORMs. In the DB it will still be a string
/deploy