Create angular module dashboard #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // request to the backend | ||
| self.sortBy = function(field, order) { | ||
| self.invoiceService.getList('', field, order); |
Contributor
There was a problem hiding this comment.
wrong. the first parameter in this function is params which is a dictionary not a blank string. You put the Query parameter in that param.
DO NOT add unnecessary/duplicate function parameters
| self.sort = function (field) { | ||
| self.order = self.order == 0 ? 1 : 0; | ||
|
|
||
| if(self.order === 0) { |
Contributor
There was a problem hiding this comment.
bad practice. find a better approach
jkingz
force-pushed
the
feature/dashboard
branch
from
a3f49dc to
3bd9e8a
Compare
jkingz
force-pushed
the
feature/dashboard
branch
from
23e8a93 to
d1576ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes
reference