Random Tweaks #172
Merged
Random Tweaks #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Honestly, this does nothing to help us, it just annoys me that GitHub thinks this is a CSS repository 😂 Ignores all the theme information, and maps Leaf to HTML (since it basically is).
There was a problem hiding this comment.
Pull request overview
This PR implements several minor tweaks across the application, including conditional middleware logging, team member classification, and event filtering by conference.
Key changes:
- Added conditional route logging that only runs in non-production environments to avoid duplicate logging with GCR
- Introduced a
coreboolean field toTeamMemberto distinguish core team members from day-of volunteers - Added conference filtering to schedule API endpoints to ensure only relevant events are returned
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/App/configure.swift | Wrapped route logging middleware in environment check to prevent duplicate logs in production |
| Sources/App/Features/Team/Models/TeamResponse.swift | Added core boolean field to TeamMember model |
| Sources/App/Features/Team/Controllers/TeamAPIController.swift | Updated team member data with core flags and role updates; modified shuffle logic to group core team separately |
| Sources/App/Features/Schedule/ScheduleAPIController.swift | Added conference filtering to event query results |
| Sources/App/Features/Schedule/ScheduleAPIController+V2.swift | Added conference filtering to event query results |
| .gitattributes | Configured linguist attributes for Public directory and Leaf templates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all minor changes, see commit notes