-
-
Notifications
You must be signed in to change notification settings - Fork 5
Admin fixes #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin fixes #171
Conversation
It's still not finished but want to see it on branch deploys
adamrushy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one 👏🏼 I just added the copy alterations 👍🏼
this means we get proper logging in Google Cloud deploys...
no more gross JSON errors
| <li class="nav-item"><a href="https://swiftleeds.co.uk/" target="_blank" class="nav-link d-inline-block px-0 pt-1 pb-2">SwiftLeeds</a></li> | ||
| #elseif(event.event == "SwiftLeeds"): | ||
| <li class="nav-item"><a href="https://kotlinleeds.co.uk/" target="_blank" class="nav-link d-inline-block px-0 pt-1 pb-2">KotlinLeeds</a></li> | ||
| #endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌🏼
adamrushy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Working on removing all the hardcoded references to SwiftLeeds, and fixing the admin panel so it works fine with two panels with two conferences (wasn't actually that bad).
I've added the event into staging (as otherwise the app crashes).