Slot property deprecations & migration fixes #156
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done to ensure backward compatibility as Vapor will verify against the Model's which it no longer exists on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed during a fresh setup of this locally we had a few issues with migrations running related to deprecated properties on Slot.
I've updated the migrations to be entirely work from a fresh install and (hopefully) work on existing deployments, and fixed the fully commented out migration with a fatalError in it to stop it running, hopefully all works as expected now, famous last words, but all looks good from my side and I can create all things in my local Admin and see them on the website.
Note, this does break the seeder, I spent a bit of time trying to manually fix the SQL but I think I'll just replicate production manually by hand and then dump that SQL to get a fully correct version with 2024 and 2025's entries on as well anyways (but probably closer to the event to not leak anything 🤐).
I tried to break down the changes commit by commit to give an idea of the changes but any questions please give me a shout in case I've messed up some ordering or foreign keys based on what fields were deprecated etc.
(Example that changes are working for Slots on my local with a limited database)